Bug 1554964 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Dave Hunt [:davehunt] [he/him] ⌚️UTC from comment #12)
> (In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #6)
> > I see that all pageload tests failed because of this, while all benchmarks ran successfully. Have I missed something?
> > Still, the successfulness of the benchmarks *(which previously failed)* confirms there's something wrong when recording the **fcp**.
> 
> Why would the benchmarks fail when they're not measuring **fcp**?

That's what I was wondering also. I filed bug 1555654 to look into this.
(In reply to Dave Hunt [:davehunt] [he/him] ⌚️UTC from comment #12)
> (In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #6)
> > I see that all pageload tests failed because of this, while all benchmarks ran successfully. Have I missed something?
> > Still, the successfulness of the benchmarks *(which previously failed)* confirms there's something wrong when recording the **fcp**.
> 
> Why would the benchmarks fail when they're not measuring **fcp**?

That's what I was wondering also. I filed bug 1555654 to look into this. Seems like my patch was wrong. I should have removed **fcp** from `alert_on = ` also.

Back to Bug 1554964 Comment 13