Bug 1555197 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
During checking `track-webvtt-two-cue-layout-after-first-end.html`, I found that we would recompute cues' display state when the amount of displaying cue changes, which was implemented in bug1551385.

However, when the amount of displaying cue changes, if display cues have already had the display state, which are based on the amount of displaying cue we had last time, we should reuse them to keep them on the previous position. 

If we recompute their display state, they would be different from the one we had last time.

EX. Cue0 [0:2], Cue1 [1:5]
```
  [playing at 1s]  
*-------------------*
|        Cue1       |                  
|        Cue0       |   
*-------------------*

  [playing at 3s]  (cue0 disappear, cue1 stays in the same position)
*-------------------*
|        Cue1       |               
|                   |      
*-------------------*
```
Revision 1 by
on 
During checking `track-webvtt-two-cue-layout-after-first-end.html`, I found that we would recompute cues' display state when the amount of displaying cue changes, which was implemented in bug1551385.

However, when the amount of displaying cue changes, if display cues have already had the display state, which are based on the amount of displaying cue we had last time, we should reuse them to keep them on the previous position. 

If we recompute their display state, they would be different from the one we had last time.

EX. Cue0 [0:2], Cue1 [1:5]
```
  [playing at 1s]  
*-------------------*
|        Cue1       |                  
|        Cue0       |   
*-------------------*

  [playing at 3s]  (cue0 disappears, cue1 stays in the same position)
*-------------------*
|        Cue1       |               
|                   |      
*-------------------*
```

Back to Bug 1555197 Comment 0