Bug 1555491 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Alexei from comment #17)
> Regarding "An unexpected error occurred" errors: We at Privacy Badger should ignore these, right? Since there isn't anything Privacy Badger or the user can do about them.

"An unexpected error occurred" is basically a generic error message that is going to be raised for errors coming from IndexedDB and not clearly related to something that the extension itself has triggered and can handle (like `DataCloneError`, when some of the data being written cannot be serialized, and QuotaExceededError, when the extension is trying to write on disk more data than allowed by the quota).

As I briefly described in Comment 16, `AbortError` / `InvalidStateError` / `UnknownError` errors seem to also be triggered (instead of `QuotaExceededError`) when the disk is completely full (or it becomes completely full while IndexedDB is already processing the IndexedDB request), but that would usually mean that something external to the extension is using all the available disk space and there is likely nothing that the extension can do to handle it.

It may be worth for the extension to let the user know that it may be related to a disk full issue, so that the user is aware and may check that the disk in not full (Firefox should actually also show a yellow "warning notification bar" when it detects that the disk is almost full).
(In reply to Alexei from comment #17)
> Regarding "An unexpected error occurred" errors: We at Privacy Badger should ignore these, right? Since there isn't anything Privacy Badger or the user can do about them.

"An unexpected error occurred" is basically a generic error message that is going to be raised for errors coming from IndexedDB and not clearly related to something that the extension itself has triggered and can handle (like `DataCloneError`, when some of the data being written cannot be serialized, and `QuotaExceededError`, when the extension is trying to write on disk more data than allowed by the quota).

As I briefly described in Comment 16, `AbortError` / `InvalidStateError` / `UnknownError` errors seem to also be triggered (instead of `QuotaExceededError`) when the disk is completely full (or it becomes completely full while IndexedDB is already processing the IndexedDB request), but that would usually mean that something external to the extension is using all the available disk space and there is likely nothing that the extension can do to handle it.

It may be worth for the extension to let the user know that it may be related to a disk full issue, so that the user is aware and may check that the disk in not full (Firefox should actually also show a yellow "warning notification bar" when it detects that the disk is almost full).

Back to Bug 1555491 Comment 18