Hi Jan! With this patch stack we will now structure clone Error objects. That means they can be potentially persisted in indexedDB. (I intentionally did not allow the saving of SavedFrames, i.e. what is required for Error.stack, because that would mean writing principals to disk)
Anyway. I am running into reproducible issue with the test `toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js`. It seems like the issue is related to indexedDB somehow. Luca kindly helped me with some debugging here and came up with the follwing:
>It seems that the key cursor created internally ExtensionStorageIDB isEmpty is returning a key but at a first glance it looks like garbage data, in >BackgroundCursorChild<CursorType>::RecvResponse at line 3472 (https://searchfox.org/mozilla-central/rev/d4b9c457db637fde655592d9e2048939b7ab2854/dom/indexedDB/ActorsChild.cpp#3472) inspecting >aResponse.get_ArrayOfObjectStoreKeyCursorResponse() does show the following:
>(rr) p aResponse.get_ArrayOfObjectStoreKeyCursorResponse()
$7 = nsTArray<mozilla::dom::indexedDB::ObjectStoreKeyCursorResponse> & = {{key_ = {mBuffer = "0gblf`jowbmje`lfz", static kMaxArrayCollapse = 3 '\003', static kMaxRecursionDepth = 64 '@'}}}
Bug 1556604 Comment 16 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Hi Jan! With this patch stack we will now structure clone Error objects. That means they can be potentially persisted in indexedDB. (I intentionally did not allow the saving of SavedFrames, i.e. what is required for Error.stack, because that would mean writing principals to disk) Anyway. I am running into reproducible issue with the test `toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js`. It seems like the issue is related to indexedDB somehow. Luca kindly helped me with some debugging here and came up with the follwing: >It seems that the key cursor created internally ExtensionStorageIDB isEmpty is returning a key but at a first glance it looks like garbage data, in BackgroundCursorChild<CursorType>::RecvResponse at line 3472 (https://searchfox.org/mozilla-central/rev/d4b9c457db637fde655592d9e2048939b7ab2854/dom/indexedDB/ActorsChild.cpp#3472) inspecting aResponse.get_ArrayOfObjectStoreKeyCursorResponse() does show the following: > >(rr) p aResponse.get_ArrayOfObjectStoreKeyCursorResponse() $7 = nsTArray<mozilla::dom::indexedDB::ObjectStoreKeyCursorResponse> & = {{key_ = {mBuffer = "0gblf`jowbmje`lfz", static kMaxArrayCollapse = 3 '\003', static kMaxRecursionDepth = 64 '@'}}}