Bugzilla

In bug 1554169 we enabled ESLint for netwerk/, however we also disabled various rules. Now that bug has landed, we should work to enable the rules that were initially disabled.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
2. Download and build the Firefox source code: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build (an artifact build is sufficient).
    * If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Introduction
3. Start working on this bug.
    * Remove the [relevant lines from the top-level .eslintrc.js](https://searchfox.org/mozilla-central/rev/9eb2f739c165b4e294929f7b99fbb4d90f8a396b/.eslintrc.js#167-177)
        * Note: Don't remove the lines below the prettier comment, there's separate work ongoing for that.
    * Run `./mach eslint --fix netwerk`
    * Investigate any remaining issues raised and fix them.
      * The [ESLint website](https://eslint.org/docs/rules/) has more details for most of the rules
      * The mozilla/ rules are [documented separately](https://firefox-source-docs.mozilla.org/tools/lint/linters/eslint-plugin-mozilla.html)
      * There's also useful [information here about fixing no-undef issues](https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/ESLint#no-undef).
    * Please **check the indentation** of the changes. Use `hg diff` or equivalent to check the indentation looks correct and check the surrounding code is fine (e.g. check that the second line of function arguments aligns correctly with the line above).
    * If you have direct questions about this bug, feel free to ask here or on irc.
5. Build your change with mach build and test your change with:
    * `./mach xpcshell-test netwerk`
    * `./mach mochitest netwerk`
6. Submit the patch for review. Mark me as a reviewer (r?standard8) so I'll get an email to come look at your code. I'll be doing an initial review of the patch, then passing it to image/ peers for final review.
    * [Here's the guide](https://developer.mozilla.org/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch).
    * I strongly suggest using [moz_phab to push the patch](https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#using-moz-phab).
7. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
8. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

In bug 1554169 we enabled ESLint for netwerk/, however we also disabled various rules. Now that bug has landed, we should work to enable the rules that were initially disabled.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
2. Download and build the Firefox source code: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build (an artifact build is sufficient).
    * If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Introduction
3. Start working on this bug.
    * Remove the [relevant lines from the top-level .eslintrc.js](https://searchfox.org/mozilla-central/rev/9eb2f739c165b4e294929f7b99fbb4d90f8a396b/.eslintrc.js#204,209-212,217,219,221,232)
        * Note: Don't remove the lines below the prettier comment, there's separate work ongoing for that.
    * Run `./mach eslint --fix netwerk`
    * Investigate any remaining issues raised and fix them.
      * The [ESLint website](https://eslint.org/docs/rules/) has more details for most of the rules
      * The mozilla/ rules are [documented separately](https://firefox-source-docs.mozilla.org/tools/lint/linters/eslint-plugin-mozilla.html)
      * There's also useful [information here about fixing no-undef issues](https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/ESLint#no-undef).
    * Please **check the indentation** of the changes. Use `hg diff` or equivalent to check the indentation looks correct and check the surrounding code is fine (e.g. check that the second line of function arguments aligns correctly with the line above).
    * If you have direct questions about this bug, feel free to ask here or on irc.
5. Build your change with mach build and test your change with:
    * `./mach xpcshell-test netwerk`
    * `./mach mochitest netwerk`
6. Submit the patch for review. Mark me as a reviewer (r?standard8) so I'll get an email to come look at your code. I'll be doing an initial review of the patch, then passing it to image/ peers for final review.
    * [Here's the guide](https://developer.mozilla.org/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch).
    * I strongly suggest using [moz_phab to push the patch](https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#using-moz-phab).
7. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
8. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.