Bug 1558313 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Jenine from comment #2)
> (In reply to Robert Relyea from comment #0)
> 
> I'm caveating my attempt with how I'm new to the codebase and I haven't run the appropriate tests yet but I wanted to confirm:
> 
> - This bug is about checks against pointers which could be NULL (found by Clang warnings)
Yes.
> - This bug is not about editing the switch statement in question (but highlighting how from that switch statement, the line PORT_FreeArena(epki->arena, PR_TRUE); can be called as a result from the default case
The crv var is set twice in those switches, but the last one is not read (if). We have to add another test of crv.
> 
> Thanks
Revision 1 by
on 
(In reply to Jenine from comment #2)
> (In reply to Robert Relyea from comment #0)
> 
> I'm caveating my attempt with how I'm new to the codebase and I haven't run the appropriate tests yet but I wanted to confirm:
> 
> - This bug is about checks against pointers which could be NULL (found by Clang warnings)

Yes.

> - This bug is not about editing the switch statement in question (but highlighting how from that switch statement, the line PORT_FreeArena(epki->arena, PR_TRUE); can be called as a result from the default case

The crv var is set twice in those switches, but the last one is not read (if). We have to add another test of crv.

> 
> Thanks

Back to Bug 1558313 Comment 3