Adding a 3rd patch (part3).
On a closer look into the "View / Calendar / Current View" menu issues -- in both the appmenu and the main "View" menu, the "Tasks in View" and "Show Completed Tasks" items were not working when the current calendar view was "Month". Other calendar views were fine. ("date" argument was undefined error.) This patch is a simple fix for that. It did not seem to warrant its own bug.
In that same "Current View" menu the "Rotate View" item can cause an intermittent error which is quite bad. ("Too much recursion".) It has to do with the "adjustScrollBarSpacers" function. I'll open a separate bug for that with more details.
The "Workweek days only" item in that menu works fine.
Bug 1558599 Comment 10 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Adding a 3rd patch (part3).
On a closer look into the "View / Calendar / Current View" menu issues -- in both the appmenu and the main "View" menu, the "Tasks in View" and "Show Completed Tasks" items were not working when the current calendar view was "Month". Other calendar views were fine. ("date" argument was undefined error.) This patch is a simple fix for that. It did not seem to warrant its own bug.
In that same "Current View" menu the "Rotate View" item can cause an intermittent error which is quite bad. ("Too much recursion".) It has to do with the "adjustScrollBarSpacers" function. I'll open a separate bug for that with more details. [EDIT: this is now bug1561093]
The "Workweek days only" item in that menu works fine.