Bug 1559659 Comment 21 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Kris Wright :KrisWright from comment #20)
> Do you know if there are any key differences to allocation or to GlobalHelperThreadState in android that would make the context list unable to be destroyed?

The thing that's failing is this assertion (about TlsContext being not set): https://hg.mozilla.org/integration/autoland/file/9f68b578bdfcb96f8b3508a254a5f6e2aa582d87/js/src/vm/HelperThreads.cpp#l1235

What's happening is probably that we're leaking a JSRuntime on shutdown, the case warned about here: https://searchfox.org/mozilla-central/rev/b9041f813de0a05bf6de95a145d4e25004499517/js/src/vm/Initialization.cpp#198

Try removing the assertion or change to a `MOZ_ASSERT_IF(JSRuntime::hasLiveRuntimes(), ...)` and see if that helps on Try?
(In reply to Kris Wright :KrisWright from comment #20)
> Do you know if there are any key differences to allocation or to GlobalHelperThreadState in android that would make the context list unable to be destroyed?

The thing that's failing is this assertion (about TlsContext being not set): https://hg.mozilla.org/integration/autoland/file/9f68b578bdfcb96f8b3508a254a5f6e2aa582d87/js/src/vm/HelperThreads.cpp#l1235

What's happening is probably that we're leaking a JSRuntime on shutdown, the case warned about here: https://searchfox.org/mozilla-central/rev/b9041f813de0a05bf6de95a145d4e25004499517/js/src/vm/Initialization.cpp#198

Try removing the assertion or change to a `MOZ_ASSERT_IF(!JSRuntime::hasLiveRuntimes(), ...)` and see if that helps on Try?

Back to Bug 1559659 Comment 21