Bug 1560343 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

So… I tried stubbing out react-intl to see the performance behavior, and it looks like it reproduces the win64 ~10% improvement to startup_about_home_paint, tart, sessionrestore, ts_paint and various others

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=2901d32eddaa6accd04b30725c7307338e94f48f&newProject=try&newRevision=cbc43ed43aa99c0e70dc359bda17039ba5f623c7&showOnlyImportant=1&showOnlyConfident=1

Here's the code changes but nothing too interesting -- just stubbing enough for the page to not throw exceptions. And looks like the attached screenshot (some strings come from content / layout but no strings in search box or context menu):
https://hg.mozilla.org/try/rev/cbc43ed43aa99c0e70dc359bda17039ba5f623c7

k88hudson, any ideas? I guess react-intl might be causing additional re-renders or perhaps these talos tests happen to measure some load event that happens to get delayed by react-intl (but not by fluent-dom)… ??
So… I tried stubbing out react-intl (relative to mozilla-central without any fluent changes) to see the performance behavior, and it looks like it reproduces the win64 ~10% improvement to startup_about_home_paint, tart, sessionrestore, ts_paint and various others

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&originalRevision=2901d32eddaa6accd04b30725c7307338e94f48f&newProject=try&newRevision=cbc43ed43aa99c0e70dc359bda17039ba5f623c7&showOnlyImportant=1&showOnlyConfident=1

Here's the code changes but nothing too interesting -- just stubbing enough for the page to not throw exceptions. And looks like the attached screenshot (some strings come from content / layout but no strings in search box or context menu):
https://hg.mozilla.org/try/rev/cbc43ed43aa99c0e70dc359bda17039ba5f623c7

k88hudson, any ideas? I guess react-intl might be causing additional re-renders or perhaps these talos tests happen to measure some load event that happens to get delayed by react-intl (but not by fluent-dom)… ??

Back to Bug 1560343 Comment 3