Bug 1562285 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Since we decided that it should be possible for generic-worker to run independently of tc-worker-runner (i.e. tc-worker-runner is an optional deployment component), it would be better for generic-worker to call `workerManager.reportWorkerError` directly rather than reporting failures to tc-worker-runner, and tc-worker-runner then forwarding the worker error on to workerManager.

I see `workerManager.reportWorkerError` as a straight replacement to the current sentry reporting in generic-worker, that avoids tying us to a particular crash reporting vendor (sentry), albeit with the acknowledged and accepted caveat that we will need to duplicate/maintain some features that existed already in sentry.

I have no problem with tc-worker-runner also reporting bootstrapping failures to workerManager, but environments without tc-worker-runner should also be able to report worker errors.
Since we decided that it should be possible for generic-worker to run independently of tc-worker-runner (i.e. tc-worker-runner is an optional deployment component), I wanted to check that you mean generic-worker should call `workerManager.reportWorkerError` directly rather than reporting failures to tc-worker-runner, and tc-worker-runner then forwarding the worker error on to workerManager.

If that's what you meant, then all is ok. :-)

Rationale: I see `workerManager.reportWorkerError` as a straight out replacement to the current sentry reporting in generic-worker, that avoids tying us to a particular crash reporting vendor (sentry), albeit with the acknowledged and accepted caveat that we will need to duplicate/maintain some features that existed already in sentry. tc-worker-runner should also reporting bootstrapping failures to workerManager, but environments without tc-worker-runner should still be able to report worker errors.
Since we decided that it should be possible for generic-worker to run independently of tc-worker-runner (i.e. tc-worker-runner is an optional deployment component), I wanted to check that you mean generic-worker should call `workerManager.reportWorkerError` directly rather than reporting failures to tc-worker-runner, and tc-worker-runner then forwarding the worker error on to workerManager.

If that's what you meant, then all is ok. :-)

Rationale: I see `workerManager.reportWorkerError` as a straight out replacement to the current sentry reporting in generic-worker, that avoids tying us to a particular crash reporting vendor (sentry), albeit with the acknowledged and accepted caveat that we will need to duplicate/maintain some features that existed already in sentry. tc-worker-runner should also report bootstrapping failures to workerManager, but environments without tc-worker-runner should still be able to report worker errors.

Back to Bug 1562285 Comment 1