I "effectively" removed my changes and applied your patch. Don't see any difference and bug still occurs like before (replacement chars in reflected recipient addresses, points greater than U+01FF have upper by masked to zero). Then I put my changes back along side your patch and it's fixed again. But I'll do as you suggest and shelve all my changes (including the mozilla code, UTF8=ACCEPT and SMTPUTF8 changes) back to pristine trunk and apply your patch to make sure I'm not somehow breaking it. It'll probably take a while to build so I'll report back what I see when it finishes... Ok, it took a while to build but I don't see any difference. Just to be clear, the upper byte getting masked off here https://searchfox.org/mozilla-central/rev/491612fa0be0f809069ea62c6316bf452cacc816/js/src/jsapi.cpp#4532 is not the only problem. The changes I did here are the primary fix: https://searchfox.org/comm-central/rev/085526b22865ea90738d779fa14bf711d46f69d3/mailnews/mime/jsmime/jsmime.js#684 But maybe there are other interfaces that need fixed?
Bug 1563891 Comment 32 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I "effectively" removed my changes and applied your patch. Don't see any difference and bug still occurs like before (replacement chars in reflected recipient addresses, points greater than U+01FF have upper byte masked to zero). Then I put my changes back along side your patch and it's fixed again. But I'll do as you suggest and shelve all my changes (including the mozilla code, UTF8=ACCEPT and SMTPUTF8 changes) back to pristine trunk and apply your patch to make sure I'm not somehow breaking it. It'll probably take a while to build so I'll report back what I see when it finishes... Ok, it took a while to build but I don't see any difference. Just to be clear, the upper byte getting masked off here https://searchfox.org/mozilla-central/rev/491612fa0be0f809069ea62c6316bf452cacc816/js/src/jsapi.cpp#4532 is not the only problem. The changes I did here are the primary fix: https://searchfox.org/comm-central/rev/085526b22865ea90738d779fa14bf711d46f69d3/mailnews/mime/jsmime/jsmime.js#684 But maybe there are other interfaces that need fixed?
I "effectively" removed my changes and applied your patch. Don't see any difference and bug still occurs like before (replacement chars in reflected recipient addresses, points equal to or greater than U+01FF have upper byte masked to zero). Then I put my changes back along side your patch and it's fixed again. But I'll do as you suggest and shelve all my changes (including the mozilla code, UTF8=ACCEPT and SMTPUTF8 changes) back to pristine trunk and apply your patch to make sure I'm not somehow breaking it. It'll probably take a while to build so I'll report back what I see when it finishes... Ok, it took a while to build but I don't see any difference. Just to be clear, the upper byte getting masked off here https://searchfox.org/mozilla-central/rev/491612fa0be0f809069ea62c6316bf452cacc816/js/src/jsapi.cpp#4532 is not the only problem. The changes I did here are the primary fix: https://searchfox.org/comm-central/rev/085526b22865ea90738d779fa14bf711d46f69d3/mailnews/mime/jsmime/jsmime.js#684 But maybe there are other interfaces that need fixed?