In duplicate bug 1607695, new contributor Michael W. had provided a patch some months ago, which imo fixes this bug quite elegantly. Magnus said r- citing focus problems. Assignee had questions on the review which unfortunately hadn't received a reply until now. I have rebased and tested the patch locally (not yet attached here), and it still works perfectly, exactly as expected. For certain click patterns involving the Save button on attachment header, indeed focus is force-changed to the message list a bit prematurely as the slower file picker opens async and is overtaken by the subsequent focus change. However, that minor disorder has been there before the patch, and it doesn't seem to cause any problems as save dialogs are always correctly focused, so we can fix that in a follow-up bug. I propose to rebase this and land essentially as-is, with some nits like var vs. let and comment capitalization.
Bug 1565007 Comment 22 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
In duplicate bug 1607695, new contributor Michael W. had provided a patch some months ago, which imo fixes this bug quite elegantly. Magnus said r- citing focus problems. Assignee had questions on the review which unfortunately hadn't received a reply until now. I have rebased and tested the patch locally (not yet attached here), and it still works perfectly, exactly as expected. For certain click patterns involving the Save button on attachment header, indeed focus is force-changed to the message list a bit prematurely as the slower file picker opens async and is overtaken by the subsequent focus change. However, that minor disorder has been there before the patch, and it doesn't seem to cause any problems as save dialogs are always correctly focused, so we can fix that in a follow-up bug. I suggest to rebase this and land essentially as-is, with some nits like var vs. let and comment capitalization.