Bug 1565827 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

We could fix it by making sure the screenshot width a multiple of 64, yes. But I don't think setting ScreenshotSize() to 384x384 is quite be enough - currently on my device the size we choose is 213x350, because the width and height are both scaled to fit inside 350x350. If we changed it to 384 it'd choose 233x284 or something like that, and will choose something else on a screen with a different aspect ratio. So the scaling logic needs to be a wee bit smarter.
We could fix it by making sure the screenshot width a multiple of 64, yes. But I don't think setting ScreenshotSize() to 384x384 is quite be enough - currently on my device the size we choose is 213x350, because the width and height are both scaled to fit inside 350x350. If we changed it to 384 it'd choose 233x384 or something like that, and will choose something else on a screen with a different aspect ratio. So the scaling logic needs to be a wee bit smarter.
We could fix it by making sure the screenshot width a multiple of 64, yes. But I don't think setting ScreenshotSize() to 384x384 is quite be enough - currently on my device the size we choose is 213x350, because the width and height are both scaled to fit inside 350x350. If we changed it to 384 it'd choose 233x384 or something like that, and will choose something else on a screen with a different aspect ratio. So the logic to choose the scale needs to be a wee bit smarter.

Back to Bug 1565827 Comment 3