Bug 1566527 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Some instructions for anyone interested:

1) The waterfall column is rendered here
https://searchfox.org/mozilla-central/rev/4fbcfe6fecf75d7b828fbebda79a31385f7eab5f/devtools/client/netmonitor/src/components/RequestListItem.js#326

2) It's rendered only if visible i.e. if `columns.waterfall` is true

3) There condition should be extended to also check state of the sidebar

Something like:
`columns.waterfall && sideClosed`

4) The state of the sidebar visibility is stored in the UI reducer
https://searchfox.org/mozilla-central/rev/4fbcfe6fecf75d7b828fbebda79a31385f7eab5f/devtools/client/netmonitor/src/reducers/ui.js#75

5) The way how to get access to the state is visible e.g. here 
https://searchfox.org/mozilla-central/rev/4fbcfe6fecf75d7b828fbebda79a31385f7eab5f/devtools/client/netmonitor/src/components/RequestListContent.js#404

So, we should pass the `networkDetailsOpen` into the `RequestListItem` as a prop somewhere here
https://searchfox.org/mozilla-central/rev/4fbcfe6fecf75d7b828fbebda79a31385f7eab5f/devtools/client/netmonitor/src/components/RequestListContent.js#374-392

Honza
Revision 1 by
on 
Some instructions for anyone interested:

1) The waterfall column is rendered here
https://searchfox.org/mozilla-central/rev/4fbcfe6fecf75d7b828fbebda79a31385f7eab5f/devtools/client/netmonitor/src/components/RequestListItem.js#326

2) It's rendered only if visible i.e. if `columns.waterfall` is true

3) There condition should be extended to also check state of the sidebar

Something like:
`columns.waterfall && sideClosed`

4) The state of the sidebar visibility is stored in the UI reducer
https://searchfox.org/mozilla-central/rev/4fbcfe6fecf75d7b828fbebda79a31385f7eab5f/devtools/client/netmonitor/src/reducers/ui.js#75

5) The state is accessed here 
https://searchfox.org/mozilla-central/rev/4fbcfe6fecf75d7b828fbebda79a31385f7eab5f/devtools/client/netmonitor/src/components/RequestListContent.js#404

So, we should pass the `networkDetailsOpen` into the `RequestListItem` as a prop somewhere here
https://searchfox.org/mozilla-central/rev/4fbcfe6fecf75d7b828fbebda79a31385f7eab5f/devtools/client/netmonitor/src/components/RequestListContent.js#374-392

Honza

Back to Bug 1566527 Comment 3