Aderk doesn't support reporting based on custom properties, so we will switch to keywords. 1. In adzerk/api.py, modify __add_targeting to set `keywords` instead of `properties`. Countries should be prefixed by `country-` and regions should be prefixed by `region-`. 2. Write a test in `tests/test_adzerk_api.py` to verify keywords are correctly passed to AdZerk. 3. Deploy the service to Pocket-Dev. 4. Go through QA steps. QA: - Target globally: ad should show up. (no keywords) - Target the U.S.: ad should show up. ``` country-US ``` - Target California: ad should show up. ``` country-US, region-CA ``` - Target the west coast: ad should show up. ``` country-US, region-CA country-US, region-OR country-US, region-WA ``` - Target a different country: ad should not show up. ``` country-CA, region-CA ```
Bug 1568583 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Aderk doesn't support reporting based on custom properties, so we will switch to keywords. 1. In adzerk/api.py, modify __add_targeting to set `keywords` instead of `properties`. Countries should be prefixed by `country-` and regions should be prefixed by `region-`. 2. Write a test in `tests/test_adzerk_api.py` to verify keywords are correctly passed to AdZerk. 3. Deploy the service to Pocket-Dev. 4. Go through QA steps. QA: - Target globally: ad should show up. (no keywords) - Target the U.S.: ad should show up. ``` country-US ``` - Target California: ad should show up. ``` country-US,region-CA ``` - Target the west coast: ad should show up. ``` country-US,region-CA country-US,region-OR country-US,region-WA ``` - Target a different country: ad should not show up. ``` country-CA,region-CA ``` - Verify whether spaces after/before a comma matter: ad should show up. ``` country-US , region-CA ```
Aderk doesn't support reporting based on custom properties, so we will switch to keywords. 1. In adzerk/api.py, modify __add_targeting to set `keywords` instead of `properties`. Countries should be prefixed by `country-` and regions should be prefixed by `region-`. 2. Write a test in `tests/test_adzerk_api.py` to verify keywords are correctly passed to AdZerk. 3. Deploy the service to Pocket-Dev. 4. Hit the /spocs endpoint on the staging server and verify the keywords show up in the `__debug__` object. 5. Create an ad in AdZerk and go through QA steps below. QA: - Target globally: ad should show up. (no keywords) - Target the U.S.: ad should show up. ``` country-US ``` - Target California: ad should show up. ``` country-US,region-CA ``` - Target the west coast: ad should show up. ``` country-US,region-CA country-US,region-OR country-US,region-WA ``` - Target a different country: ad should not show up. ``` country-CA,region-CA ``` - Verify whether spaces after/before a comma matter: ad should show up. ``` country-US , region-CA ```