Bug 1569475 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Cool, here are two test runs from comment 7 that are green (woohoo) and include the NS_ERROR from this patch (showing that we are indeed intervening & preventing a fatal assertion-failure):
https://treeherder.mozilla.org/logviewer.html#?job_id=259085993&repo=try
https://treeherder.mozilla.org/logviewer.html#?job_id=259086002&repo=try

You can see the NS_ERROR failure if you load those^ logs, click the "open raw log" button at the top, and then search for "ClampZoom". That shows something like this, which is the new expected non-fatal failure mode after the attached patch is applied:
```
INFO - TEST-PASS | devtools/client/responsive.html/test/browser/browser_viewport_resizing_fixed_width_and_zoom.js | Meta Viewport ON return to initial size should have expected layout height. - 
INFO - Closing responsive design mode
INFO - GECKO(1696) | [Parent 1696, Main Thread] WARNING: '!CanHandleWith(sPresContext)', file /builds/worker/workspace/build/src/dom/events/IMEStateManager.cpp, line 1152
INFO - GECKO(1696) | [Child 1699, Main Thread] ###!!! ASSERTION: Don't pass NaN to ClampZoom; check caller for 0/0 division: 'Error', file /builds/worker/workspace/build/src/layout/base/MobileViewportManager.cpp, line 176
INFO - GECKO(1696) | #01: MobileViewportManager::UpdateResolution(nsViewportInfo const&, mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, mozilla::gfx::SizeTyped<mozilla::CSSPixel, float> const&, mozilla::Maybe<float> const&, MobileViewportManager::UpdateType) [gfx/2d/ScaleFactor.h:34]
INFO - 
INFO - GECKO(1696) | #02: MobileViewportManager::RefreshViewportSize(bool) [layout/base/MobileViewportManager.cpp:563]
INFO - 
INFO - GECKO(1696) | #03: mozilla::PresShell::UpdateViewportOverridden(bool) [layout/base/PresShell.cpp:10595]
INFO - 
INFO - GECKO(1696) | #04: non-virtual thunk to nsDocShell::SetMetaViewportOverride(nsIDocShell::MetaViewportOverride) [docshell/base/nsDocShell.cpp:0]
```
Revision 1 by
on 
Cool, here are two test runs from comment 7 that are green (woohoo) and include a report of the `NS_ERROR` from this patch (showing that we are indeed intervening & preventing a fatal assertion-failure):
https://treeherder.mozilla.org/logviewer.html#?job_id=259085993&repo=try
https://treeherder.mozilla.org/logviewer.html#?job_id=259086002&repo=try

You can see the NS_ERROR failure if you load those^ logs, click the "open raw log" button at the top, and then search for "ClampZoom". That shows something like this, which is the new expected non-fatal failure mode after the attached patch is applied:
```
INFO - TEST-PASS | devtools/client/responsive.html/test/browser/browser_viewport_resizing_fixed_width_and_zoom.js | Meta Viewport ON return to initial size should have expected layout height. - 
INFO - Closing responsive design mode
INFO - GECKO(1696) | [Parent 1696, Main Thread] WARNING: '!CanHandleWith(sPresContext)', file /builds/worker/workspace/build/src/dom/events/IMEStateManager.cpp, line 1152
INFO - GECKO(1696) | [Child 1699, Main Thread] ###!!! ASSERTION: Don't pass NaN to ClampZoom; check caller for 0/0 division: 'Error', file /builds/worker/workspace/build/src/layout/base/MobileViewportManager.cpp, line 176
INFO - GECKO(1696) | #01: MobileViewportManager::UpdateResolution(nsViewportInfo const&, mozilla::gfx::IntSizeTyped<mozilla::ScreenPixel> const&, mozilla::gfx::SizeTyped<mozilla::CSSPixel, float> const&, mozilla::Maybe<float> const&, MobileViewportManager::UpdateType) [gfx/2d/ScaleFactor.h:34]
INFO - 
INFO - GECKO(1696) | #02: MobileViewportManager::RefreshViewportSize(bool) [layout/base/MobileViewportManager.cpp:563]
INFO - 
INFO - GECKO(1696) | #03: mozilla::PresShell::UpdateViewportOverridden(bool) [layout/base/PresShell.cpp:10595]
INFO - 
INFO - GECKO(1696) | #04: non-virtual thunk to nsDocShell::SetMetaViewportOverride(nsIDocShell::MetaViewportOverride) [docshell/base/nsDocShell.cpp:0]
```

Back to Bug 1569475 Comment 9