Bug 1570747 Comment 22 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Sean Feng [:sefeng] from comment #21)
> I can't reproduce the long loading InitializePreferences() on the latest nightly. 
> 
> After doing some bisecting, I figured the long loading InitializePreferences() has been fixed since August 8th nightly geckoview. (Build ID:20190808093310). 
> 
> Dimi, did we land some patches around August 7th that might fixed it?

I would say no in URL Classifier.

I find the difference is that in fast loading InitializePreferences(), Remote-settings.js doesn't import RemoteSettingsClient.jsm, so it also doesn't import the other slow loading modules mentioned in Comment 6.
If I understand correctly, what Mathieu has done(Comment 10) is to delay loading kinto-http-client.js, it doesn't affect whether RemoteSettingsClient.jsm will be loaded or not.
Maybe something has changed in Remote-settings.js so we don't always import RemoteSettingsClient.jsm now?
(In reply to Sean Feng [:sefeng] from comment #21)
> I can't reproduce the long loading InitializePreferences() on the latest nightly. 
> 
> After doing some bisecting, I figured the long loading InitializePreferences() has been fixed since August 8th nightly geckoview. (Build ID:20190808093310). 
> 
> Dimi, did we land some patches around August 7th that might fixed it?

I would say no in URL Classifier.

I find the difference is that in fast loading InitializePreferences(), Remote-settings.js didn't import RemoteSettingsClient.jsm, so it also didn't import the other slow loading modules mentioned in Comment 6.
If I understand correctly, what Mathieu has done(Comment 10) is to delay loading kinto-http-client.js, it doesn't affect whether RemoteSettingsClient.jsm will be loaded or not.
Maybe something has changed in Remote-settings.js so we don't always import RemoteSettingsClient.jsm now?
(In reply to Sean Feng [:sefeng] from comment #21)
> I can't reproduce the long loading InitializePreferences() on the latest nightly. 
> 
> After doing some bisecting, I figured the long loading InitializePreferences() has been fixed since August 8th nightly geckoview. (Build ID:20190808093310). 
> 
> Dimi, did we land some patches around August 7th that might fixed it?

I would say no in URL Classifier.

I find the difference is that in those profiles with fast loading InitializePreferences(), Remote-settings.js didn't import RemoteSettingsClient.jsm, so it also didn't import the other slow loading modules mentioned in Comment 6.
If I understand correctly, what Mathieu has done(Comment 10) is to delay loading kinto-http-client.js, it doesn't affect whether RemoteSettingsClient.jsm will be loaded or not.
Maybe something has changed in Remote-settings.js so we don't always import RemoteSettingsClient.jsm now?

Back to Bug 1570747 Comment 22