Bug 1571672 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

> Hmm... do we ever send a charset? I didn't find where. Maybe it should be fixed at that point if we do.

Yes we do send "search charset <spec> ..." here:
https://searchfox.org/comm-central/rev/edbbc461dc1489444ca7ab72fe5da32c826b28fe/mailnews/base/search/src/nsMsgImapSearch.cpp#110

I too preferred to just skip putting it in at that point instead of taking it out later. However, we only want to not put it in when capability UTF8=ACCEPT has been enabled. I don't know how make this known in nsMsgImapSearch.cpp when the enable occurs in nsImapProtocol.cpp. Maybe an access function of some sort?
> Hmm... do we ever send a charset? I didn't find where. Maybe it should be fixed at that point if we do.

Yes we do send "search charset <spec> ..." here:
https://searchfox.org/comm-central/rev/edbbc461dc1489444ca7ab72fe5da32c826b28fe/mailnews/base/search/src/nsMsgImapSearch.cpp#110

I too preferred to just skip putting it in at that point instead of taking it out later. However, we only want to not put it in when capability UTF8=ACCEPT has been enabled. I don't know how make this known in nsMsgImapSearch.cpp when the enable occurs in nsImapProtocol.cpp. Maybe an access function of some sort?

Edit: Looking closer at this, I can't figure it out. If you really want this and think it can be done, I need some good advice on how to do it.

> usually better to do the positive form. maybe useUTF8Accept

No problem, I can do this.

Back to Bug 1571672 Comment 13