I remember doing that but never made a note as to why. So I went back and retested and tried to recall why I did it. It looks like the change is not needed but doesn't break anything. I think I was concern that with non-ascii addresses that the parsing would fail and produce the wrong count of the number of addresses. However unlike with Bug 1658361 that also changed parseEncodedHeader to parseEncodedHeadeW, the actual parsed address strings are not used here but just the count of the number of address strings so the proper count is returned which determines if the "Reply All" button is enabled or not. I'll remove this from the patch since it really doesn't apply to this bug even if there were a problem.
Bug 1571672 Comment 73 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I remember doing that but never made a note as to why. So I went back and retested and tried to recall why I did it. It looks like the change is not needed but doesn't break anything. I think I was concern that with non-ascii addresses that the parsing would fail and produce the wrong count of the number of addresses. However unlike with Bug 1658361 that also changed parseEncodedHeader to parseEncodedHeadeW, the actual parsed address strings are not used here but just the count of the number of address strings so the proper count is returned which determines if the "Reply All" button is enabled or not. I'll remove this from the patch since it really doesn't apply to this bug even if there was a problem.