Bug 1572047 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Geoff Lankow (:darktrojan) from comment #14)
> Some of those rules were removed from mozilla-central when they turned on Prettier. They were added to our config because we had Prettier disabled and wanted to keep the checks.
> 
> https://hg.mozilla.org/comm-central/rev/1ba917da139c6e707d6d964c5d1de142cab1e666

Aha, nice.  So we can remove these again, which takes care of "generator-star-spacing".  

Looks like the main question is #3 -- whether calendar wants to have the prettier setting |"quoteProps": "consistent"| or just go with the prettier default |"quoteProps": "as-needed"|.
Revision 1 by
on 
(In reply to Geoff Lankow (:darktrojan) from comment #14)
> Some of those rules were removed from mozilla-central when they turned on Prettier. They were added to our config because we had Prettier disabled and wanted to keep the checks.
> 
> https://hg.mozilla.org/comm-central/rev/1ba917da139c6e707d6d964c5d1de142cab1e666

Aha, nice, thanks.  So we can remove these again, which takes care of "generator-star-spacing".  

Looks like the main question is #3 -- whether calendar wants to have the prettier setting |"quoteProps": "consistent"| or just go with the prettier default |"quoteProps": "as-needed"|.

Back to Bug 1572047 Comment 16