Just get a question. For now, there are 3 kinds of properties: 1. Shipped CSS properties, e.g. `width` 2. No-shipped-yet CSS properties (i.e. developing CSS properties), e.g. `column-span`, `offset-path`, `-webkit-app-region` 3. Unimplemented CSS properties, e.g. `zoom` The current implementation is for (1) and (2) (pref: layout.css.use-counters.enabled), and I'm working on (3). However, the list in comment 1 also includes (2). That means the phf in `parse_unchecked()` would have duplicate entries because of (2). So I'd like to remove (2) from the list in comment 1, and do some trick things, based on our decision. So now, I would like to make sure the purpose in this: do we want to record (2) in this bug? (or even together with (1)) * If (1) and (2) and (3) all should be recorded, we perhaps only need one preference (i.e. layout.css.use-counters.enabled), and the code might be simpler. * if we just record (2) and (3), this may be a little bit tricky, and I need to maintain an extra list for (2). * if only (3), this is trivial, I think. May need Tim or Emilio's feedback. Thanks.
Bug 1575062 Comment 11 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Just get a question. For now, there are 3 kinds of properties: 1. Shipped CSS properties, e.g. `width` 2. No-shipped-yet CSS properties (i.e. developing CSS properties), e.g. `column-span`, `offset-path`, `-webkit-app-region` 3. Unimplemented CSS properties, e.g. `zoom` The current implementation is for (1) and (2) (pref: layout.css.use-counters.enabled), and I'm working on (3). However, the list in comment 1 also includes (2). That means the phf in `parse_unchecked()` has duplicate entries because of (2). So I'd like to remove (2) from the list in comment 1, and do some trick things, based on our decision. So now, I would like to make sure the purpose in this: do we want to record (2) in this bug? (or even together with (1)) * If (1) and (2) and (3) all should be recorded, we perhaps only need one preference (i.e. layout.css.use-counters.enabled), and the code might be simpler. * if we just record (2) and (3), this may be a little bit tricky, and I need to maintain an extra list for (2). * if only (3), this is trivial, I think. May need Tim or Emilio's feedback. Thanks.
Just get a question. For now, there are 3 kinds of properties: 1. Shipped CSS properties, e.g. `width` 2. No-shipped-yet CSS properties (i.e. developing CSS properties), e.g. `column-span`, `offset-path`, `-webkit-app-region` 3. Unimplemented CSS properties, e.g. `zoom` The current implementation is for (1) and (2) (pref: layout.css.use-counters.enabled), and I'm working on (3). However, the list in comment 1 also includes (2). That means the phf-map in `parse_unchecked()` has duplicate entries because of (2). So I'd like to remove (2) from the list in comment 1, and do some trick things, based on our decision. So now, I would like to make sure the purpose in this: do we want to record (2) in this bug? (or even together with (1)) * If (1) and (2) and (3) all should be recorded, we perhaps only need one preference (i.e. layout.css.use-counters.enabled), and the code might be simpler. * if we just record (2) and (3), this may be a little bit tricky, and I need to maintain an extra list for (2). * if only (3), this is trivial, I think. May need Tim or Emilio's feedback. Thanks.