Bug 1577236 Comment 39 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Here is another one that only comes up on Windows:

```
[task 2019-11-20T19:15:08.157Z] z:/task_1574273573/src/mozglue/misc/TimeStamp_windows.cpp(385,16): error: implicit conversion from 'long long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
[task 2019-11-20T19:15:08.157Z]   if (result > INT64_MAX) {
[task 2019-11-20T19:15:08.157Z]              ~ ^~~~~~~~~
[task 2019-11-20T19:15:08.157Z] z:\task_1574273573\vs2017_15.8.4\VC\include\stdint.h(55,26): note: expanded from macro 'INT64_MAX'
[task 2019-11-20T19:15:08.157Z] #define INT64_MAX        9223372036854775807i64
[task 2019-11-20T19:15:08.157Z]                          ^~~~~~~~~~~~~~~~~~~~~~
```
Revision 1 by
on 
Here is another one that only comes up on Windows:

```
[task 2019-11-20T19:15:08.157Z] z:/task_1574273573/src/mozglue/misc/TimeStamp_windows.cpp(385,16): error: implicit conversion from 'long long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
[task 2019-11-20T19:15:08.157Z]   if (result > INT64_MAX) {
[task 2019-11-20T19:15:08.157Z]              ~ ^~~~~~~~~
[task 2019-11-20T19:15:08.157Z] z:\task_1574273573\vs2017_15.8.4\VC\include\stdint.h(55,26): note: expanded from macro 'INT64_MAX'
[task 2019-11-20T19:15:08.157Z] #define INT64_MAX        9223372036854775807i64
[task 2019-11-20T19:15:08.157Z]                          ^~~~~~~~~~~~~~~~~~~~~~
```

Edit: I see the same code in TimeStamp_darwin.cpp too.

Back to Bug 1577236 Comment 39