Bug 1577548 Comment 122 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Barry S.  Finkel from comment #121)
> Gene, another comment.   If TB recovers from a temp error, then I do not need to know that fact (other to conclude the first time that the revised code is working).  I see no need for a pop-up window where the user has to acknowledge.

Well, if you click on "Get Messages" and you receive no new messages due to SYS/TEMP and some are actually available you might want to know something went temporarily wrong and you might want to try again.

Anyhow, I'm pretty sure I now know why you don't see any error dialogs when the random SYS/TEMPs occur. The Error() function is still actually getting called but because polling for new messages occurs in "biff" mode (biff is a weird term for checking for new mail via a timer) TB assumes there is no "window" to display the dialog onto. So inside Error(), if the "window" pointer comes back null, there is not attempt to put up a dialog. (I worked on another bug recently involving this but somehow I didn't notice this inside Error() until just now. Duh.)

So what this means is that I don't need the special notification and will just let it be a normal dialog with the OK button. This dialog for SYS/TEMP will only appear if SYS/TEMP occurs when you do "Get Messages" by clicking.

I'll need to update the patch one more time.
(In reply to Barry S.  Finkel from comment #121)
> Gene, another comment.   If TB recovers from a temp error, then I do not need to know that fact (other to conclude the first time that the revised code is working).  I see no need for a pop-up window where the user has to acknowledge.

Well, if you click on "Get Messages" and you receive no new messages due to SYS/TEMP and some are actually available you might want to know something went temporarily wrong and you might want to try again.

Anyhow, I'm pretty sure I now know why you don't see any error dialogs when the random SYS/TEMPs occur. The Error() function is still actually getting called but because polling for new messages occurs in "biff" mode (biff is a weird term for checking for new mail via a timer) TB assumes there is no "window" to display the dialog onto. So inside Error(), if the "window" pointer comes back null, there is no attempt to put up a dialog. (I worked on another bug recently involving this but somehow I didn't notice this inside Error() until just now. Duh.)

So what this means is that I don't need the special notification and will just let it be a normal dialog with the OK button. This dialog for SYS/TEMP will only appear if SYS/TEMP occurs when you do "Get Messages" by clicking.

I'll need to update the patch one more time.

Back to Bug 1577548 Comment 122