Bug 1578459 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
The failure was intermittent but high frequency (8/11 runs). The screenshot showed that the category item was marked `.notFound`, but was still disabled - i.e. `reorderCategoryItems` was never called. This means that the content blocking event was received between onpopupshowing and onpopupshown - since if it was called after the popup was shown, the items would have reordered immediately. I made two try pushes: [1] in which the test waits for the category item order to be invalidated before opening the popup, and [2] that makes `onContentBlockingEvent` call `reorderCategoryItems` immediately in the `showing` state of the popup in addition to `open`. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0f05f46b983e8e2ad511133f13c6d468b4c0564 [2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a0278faa55d4844c05117bed487fec0db056015
The failure was intermittent but high frequency (8/11 runs). The screenshot showed that the category item was marked `.notFound`, but was still disabled - i.e. `reorderCategoryItems` was never called. This means that the content blocking event was received between onpopupshowing and onpopupshown - since if it was called after the popup was shown, the items would have reordered immediately. I made two try pushes: [1] in which the test waits for the category item order to be invalidated before opening the popup, and [2] that makes `onContentBlockingEvent` call `reorderCategoryItems` immediately in the `showing` state of the popup in addition to `open`. If [2] works, we should land it. If not, I have high confidence that [1] will work. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0f05f46b983e8e2ad511133f13c6d468b4c0564 [2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a0278faa55d4844c05117bed487fec0db056015