(In reply to Jorg K (GMT+2) from comment #27) > OK, I'll push this, then Jonathan can try it in tomorrow's Daily. Also, it maintains the custom Trash if desired, right? Yes, you can assign an arbitrary folder in gmail or other servers to be trash and the icon appears and "deleted" messages are moved from the source folder to there. Other then the pro and con arguments for doing this change at all, this issue still exists that I mentioned in comment 11: Ok, I can see this as a possible problem: A user with pre-70b had selected a **not** [Gmail]/Trash folder as the trash destination. This really doesn't work and [Gmail]/Trash remains the destination even though the other folder is the value of pref "trash_folder_name". Then when a 70b user runs TB with this setup, the not [Gmail]/Trash folder becomes the trash destination. So in this case the user needs to "reset" the trash_folder_name setting in config editor or explicitly set the trash folder setting to [Gmail]/Trash in server settings to ensure that the default [Gmail]/Trash remains the trash destination. Something about this should be in the release notes.
Bug 1579304 Comment 28 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Jorg K (GMT+2) from comment #27) > OK, I'll push this, then Jonathan can try it in tomorrow's Daily. Also, it maintains the custom Trash if desired, right? Yes, you can assign an arbitrary folder in gmail or other servers to be trash and the icon appears and "deleted" messages are moved from the source folder to there. Other then the pro and con arguments for doing this change at all, this issue still exists that I mentioned in comment 11: Ok, I can see this as a possible but rare problem: A user with pre-70b had selected a **not** [Gmail]/Trash folder as the trash destination. This really doesn't work and [Gmail]/Trash remains the destination even though the other folder is the value of pref "trash_folder_name". Then when a 70b user runs TB with this setup, the not [Gmail]/Trash folder becomes the trash destination. So in this case the user needs to "reset" the trash_folder_name setting in config editor or explicitly set the trash folder setting to [Gmail]/Trash in server settings to ensure that the default [Gmail]/Trash remains the trash destination. Something about this should be in the release notes.