Bug 1580914 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Andrew Halberstadt [:ahal] from comment #2)
> It's also worth noting that even with all of the above we *still* might be missing data. That's because even if we read all `moz.build` files, the `*_MANIFEST` keys themselves could be hidden behind build configuration, like this:
> https://searchfox.org/mozilla-central/source/dom/media/moz.build#88

I think a very strong argument could be made that we shouldn't be using build metadata to filter out tests, and we should use test manifests + mozinfo instead. So a valid solution here might be to remove the manifests from these conditions and make sure they have appropriate `skip-if`s instead.
(In reply to Andrew Halberstadt [:ahal] from comment #2)
> It's also worth noting that even with all of the above we *still* might be missing data. That's because even if we read all `moz.build` files, the `*_MANIFEST` keys themselves could be hidden behind build configuration, like this:
> https://searchfox.org/mozilla-central/source/dom/media/moz.build#88

I think a very strong argument could be made that we shouldn't be using build metadata to filter out tests, and we should use test manifests + mozinfo instead. So a valid solution here might be to remove the manifests from these conditions and make sure they have appropriate `skip-if`s instead.

p.s. I just *love* how that directory has both a `test` and `tests` subdir.. and apparently `tests` means webrtc is enabled.

Back to Bug 1580914 Comment 3