Bugzilla

(In reply to Wayne Mery (:wsmwk) from comment #44)
> No decrease in crash rates on Nov 8, but there is on Nov 11.  Correlating that with [version uptake](https://stats.thunderbird.net/#version), I think we must conclude 128.4.2 had an impact.  So [one of these patches](https://bugzilla.mozilla.org/buglist.cgi?bug_id=1924437%2C1928114%2C1924927%2C1879355%2C1924637%2C1922934%2C1921313%2C1918163%2C1928232%2C1925493%2C1887518%2C1857413%2C1912675%2C1922944%2C1911916%2C1927656&list_id=17325745).

(In reply to Kai Engert [:KaiE:] from comment #45)
> If the crashes aren't completely gone, but just dropped frequency, maybe related to raising the threshold for triggering folder compact, which might cause that to happen less frequently. Just a wild guess.

Ultimately esr crash rate for nsParseMailMessageState::GetAggregateHeader stabilized, present day, at 75% reduction compared to early November.  But still not gone in esr where it ranks #2/#3.


(In reply to Magnus Melin [:mkmelin] from comment #46)
> Might be gone. We don't have 135+ crashes it seems (bug 1920051 might have fixed).

[this graph of beta, release, nightly](https://crash-stats.mozilla.org/signature/?release_channel=beta&release_channel=release&release_channel=nightly&signature=PL_strncpy%20%7C%20PL_strncat%20%7C%20nsParseMailMessageState%3A%3AGetAggregateHeader&date=%3E%3D2024-09-13T00%3A38%3A00.000Z&date=%3C2025-03-13T00%3A38%3A00.000Z#graphs) shows a significant drop in early December circa 134.0b1/134.0b2 - **way earlier than bug 1920051**, but I didn't dig deeper into the data for an explanation.   Note, there is a messy mix of 115.nn esr crashes in this query.

That said, both signatures strnlen and nsParseMailMessageState::GetAggregateHeader do indeed die in beta 135. 


(In reply to Hartmut Welpmann [:welpy-cw] from comment #47)
> 
> Apparently this signature has now moved to [memcpy | nsCharTraits<T>::copy](https://crash-stats.mozilla.org/signature/?product=Thunderbird&signature=memcpy%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&date=%3E%3D2024-07-28T11%3A15%3A00.000Z&date=%3C2025-01-28T11%3A15%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-version&_sort=-date&page=1)…

It does seem so.  And perhaps also [memcpy_avx_ermsb_Intel | nsCharTraits<T>::copy](https://crash-stats.mozilla.org/signature/?proto_signature=~nsParseMailMessageState%3A%3AFinalizeHeaders&release_channel=beta&release_channel=nightly&release_channel=release&product=Thunderbird&signature=memcpy_avx_ermsb_Intel%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&date=%3E%3D2024-09-13T01%3A33%3A00.000Z&date=%3C2025-03-13T01%3A33%3A00.000Z)

But at the same crash rate?   If you compare the crash rates of pre-135 against 135+136 (for the two new signatures) it looks to me like the crash rates are about the **same**  - [release channel](https://crash-stats.mozilla.org/search/?signature=%3Dmemcpy_avx_ermsb_Intel%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&signature=%3Dmemcpy%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&signature=%3DPL_strncpy%20%7C%20PL_strncat%20%7C%20nsParseMailMessageState%3A%3AGetAggregateHeader&release_channel=release&product=Thunderbird&date=%3E%3D2025-01-13T01%3A38%3A00.000Z&date=%3C2025-03-13T01%3A38%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature), [beta channel](https://crash-stats.mozilla.org/search/?signature=%3Dmemcpy_avx_ermsb_Intel%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&signature=%3Dmemcpy%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&signature=%3DPL_strncpy%20%7C%20PL_strncat%20%7C%20nsParseMailMessageState%3A%3AGetAggregateHeader&release_channel=beta&product=Thunderbird&date=%3E%3D2025-01-13T01%3A38%3A00.000Z&date=%3C2025-03-13T01%3A38%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature)

So 1920051 only changed the signature?

(In reply to Wayne Mery (:wsmwk) from comment #44)
> No decrease in crash rates on Nov 8, but there is on Nov 11.  Correlating that with [version uptake](https://stats.thunderbird.net/#version), I think we must conclude 128.4.2 had an impact.  So [one of these patches](https://bugzilla.mozilla.org/buglist.cgi?bug_id=1924437%2C1928114%2C1924927%2C1879355%2C1924637%2C1922934%2C1921313%2C1918163%2C1928232%2C1925493%2C1887518%2C1857413%2C1912675%2C1922944%2C1911916%2C1927656&list_id=17325745).

(In reply to Kai Engert [:KaiE:] from comment #45)
> If the crashes aren't completely gone, but just dropped frequency, maybe related to raising the threshold for triggering folder compact, which might cause that to happen less frequently. Just a wild guess.

Ultimately esr crash rate for nsParseMailMessageState::GetAggregateHeader stabilized, present day, at 75% reduction compared to early November.  But still not gone in esr where it ranks #2/#3.


(In reply to Magnus Melin [:mkmelin] from comment #46)
> Might be gone. We don't have 135+ crashes it seems (bug 1920051 might have fixed).

[this graph of beta, release, nightly](https://crash-stats.mozilla.org/signature/?release_channel=beta&release_channel=release&release_channel=nightly&signature=PL_strncpy%20%7C%20PL_strncat%20%7C%20nsParseMailMessageState%3A%3AGetAggregateHeader&date=%3E%3D2024-09-13T00%3A38%3A00.000Z&date=%3C2025-03-13T00%3A38%3A00.000Z#graphs) shows a significant drop in early December circa 134.0b1/134.0b2 - **way earlier than bug 1920051**, but I didn't dig deeper into the data for an explanation.   Note, there is a messy mix of 115.nn esr crashes in this query.

That said, both signatures strnlen and nsParseMailMessageState::GetAggregateHeader do indeed die in beta 135. 


(In reply to Hartmut Welpmann [:welpy-cw] from comment #47)
> 
> Apparently this signature has now moved to [memcpy | nsCharTraits<T>::copy](https://crash-stats.mozilla.org/signature/?product=Thunderbird&signature=memcpy%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&date=%3E%3D2024-07-28T11%3A15%3A00.000Z&date=%3C2025-01-28T11%3A15%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-version&_sort=-date&page=1)…

It does seem so.  And perhaps also [memcpy_avx_ermsb_Intel | nsCharTraits<T>::copy](https://crash-stats.mozilla.org/signature/?proto_signature=~nsParseMailMessageState%3A%3AFinalizeHeaders&release_channel=beta&release_channel=nightly&release_channel=release&product=Thunderbird&signature=memcpy_avx_ermsb_Intel%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&date=%3E%3D2024-09-13T01%3A33%3A00.000Z&date=%3C2025-03-13T01%3A33%3A00.000Z)

But at the same crash rate?   If you compare the crash rates of pre-135 against 135+136 (for the two new signatures) it looks to me like the crash rates are about the **same**  - [release channel](https://crash-stats.mozilla.org/search/?signature=%3Dmemcpy_avx_ermsb_Intel%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&signature=%3Dmemcpy%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&signature=%3DPL_strncpy%20%7C%20PL_strncat%20%7C%20nsParseMailMessageState%3A%3AGetAggregateHeader&release_channel=release&product=Thunderbird&date=%3E%3D2025-01-13T01%3A38%3A00.000Z&date=%3C2025-03-13T01%3A38%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature), [beta channel](https://crash-stats.mozilla.org/search/?signature=%3Dmemcpy_avx_ermsb_Intel%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&signature=%3Dmemcpy%20%7C%20nsCharTraits%3CT%3E%3A%3Acopy&signature=%3DPL_strncpy%20%7C%20PL_strncat%20%7C%20nsParseMailMessageState%3A%3AGetAggregateHeader&release_channel=beta&product=Thunderbird&date=%3E%3D2025-01-13T01%3A38%3A00.000Z&date=%3C2025-03-13T01%3A38%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature)

So bug 1920051 only changed the signature?