Bug 1582410 Comment 19 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I think I'll need to review this. I'm convinced that we don't want this: `document.getElementById("cmd_paragraphState").setAttribute("state", "div");` is correct. What attribute states are possible? Why does "" not work any more? Can you set "br"?

BTW, have you tried all these test cases?
- Compose in paragraph or body text mode with and without signature (4 test cases)
- Switch identity and make sure the signature is properly replaced (2 test cases)
- Reply with below the quote with and without signature. Then switch identity. (4 test cases)
- Reply above the quote with without and with signature, both above and below the quote. Then switch identity. (6 test cases).
You might also try switching between identities were one has a signature and another one doesn't.
Revision 1 by
on 
I think I'll need to review this. I'm convinced that we don't want this: `document.getElementById("cmd_paragraphState").setAttribute("state", "div");`. What attribute states are possible? Why does "" not work any more? Can you set "br"?

BTW, have you tried all these test cases?
- Compose in paragraph or body text mode with and without signature (4 test cases)
- Switch identity and make sure the signature is properly replaced (2 test cases)
- Reply with below the quote with and without signature. Then switch identity. (4 test cases)
- Reply above the quote with without and with signature, both above and below the quote. Then switch identity. (6 test cases).
You might also try switching between identities were one has a signature and another one doesn't.
Revision 2 by
on 
I think I'll need to review this. I'm convinced that we don't want this: `document.getElementById("cmd_paragraphState").setAttribute("state", "div");`. What attribute states are possible? Why does "" not work any more? Can you set "br"?

BTW, have you tried all these test cases?
- Compose in paragraph or body text mode with and without signature (4 test cases)
- Switch identity and make sure the signature is properly replaced (2 test cases)
- Reply with below the quote with and without signature. Then switch identity. (4 test cases)
- Reply above the quote with without and with signature, both above and below the quote. Then switch identity. (6 test cases).
You might also try switching between identities were one has a signature and another one doesn't.

EDIT: I forgot to say: You also need to test forwarding, there you can also add signatures and switch identities.

Back to Bug 1582410 Comment 19