Bugzilla

Sure. For FF editing. That started in FF 60 or earlier, but we never followed it, so why now, especially a week before the code goes to TB 68 beta and then ESR? Has someone looked at the potential consequences in TB(*)? As far as I read the bug, you want to "modernise" some editing commands, fair enough. So why change the "body text" make up? As you can see from the changeset quoted in comment #18, the slightest change in this area has far reaching effects. Coincidentally the patch destroys composition with signatures and has been presented for review, apparently without any testing of real life cases :-(

BTW, where is the "funny little roundtrip through c++"? 

Just a small list of possible consequences:
- What happens during HTML->plaintext conversion? How do the <div>m convert?
- How do the divs look in a reply, or plaintext reply to a HTML mail?
- What does out test suite say? No of the tests expects <div>, they all expect <br>.
- Are there any add-ons which will break now? QuickText?
- How does "Body text" to "Paragraph" conversion work if <div> is used instead of <br>?
- (That list is just a three minute brainstorming result, I'm sure there is more).
Keep in mind that composition has always happened with <br> for decades, and at some stage we switched the default to <p>.

Sure. For FF editing. That started in FF 60 or earlier, but we never followed it, so why now, especially a week before the code goes to TB 78 (EDIT: 68->78) beta and then ESR? Has someone looked at the potential consequences in TB(*)? As far as I read the bug, you want to "modernise" some editing commands, fair enough. So why change the "body text" make up? As you can see from the changeset quoted in comment #18, the slightest change in this area has far reaching effects. Coincidentally the patch destroys composition with signatures and has been presented for review, apparently without any testing of real life cases :-(

BTW, where is the "funny little roundtrip through c++"? 

Just a small list of possible consequences:
- What happens during HTML->plaintext conversion? How do the <div>m convert?
- How do the divs look in a reply, or plaintext reply to a HTML mail?
- What does out test suite say? No of the tests expects <div>, they all expect <br>.
- Are there any add-ons which will break now? QuickText?
- How does "Body text" to "Paragraph" conversion work if <div> is used instead of <br>?
- (That list is just a three minute brainstorming result, I'm sure there is more).
Keep in mind that composition has always happened with <br> for decades, and at some stage we switched the default to <p>.