Approval Request Comment [Feature/Bug causing the regression]: This bug introduced a data race between threads that read mDNSSuffixDomains by calling IsExcludedFromTRR and the main thread that changes mDNSSuffixDomains in response to the "network:link-status-changed" notification. This code hasn't gone through extensive QA testing: [relevant topic](https://jira.mozilla.com/browse/PI-335?focusedCommentId=35288&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-35288) [User impact if declined]: This can potentially cause a crash when network changes occur while a DNS request is in progress. [Is this code covered by automated tests?]: Yes, but the unit test that exercise this path are run sequentially. [Has the fix been verified in Nightly?]: This is a backout request for beta only. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: [Is the change risky?]: Very low risk. [Why is the change risky/not risky?]: This patch only removes code. This code being removed has interaction with other code and is unlikely to cause any regressions. [String changes made/needed]:
Bug 1582472 Comment 7 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Approval Request Comment [Feature/Bug causing the regression]: This bug introduced a data race between threads that read mDNSSuffixDomains by calling IsExcludedFromTRR and the main thread that changes mDNSSuffixDomains in response to the "network:link-status-changed" notification. This code hasn't gone through extensive QA testing: [relevant discussion](https://jira.mozilla.com/browse/PI-335?focusedCommentId=35288&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-35288) [User impact if declined]: This can potentially cause a crash when network changes occur while a DNS request is in progress. [Is this code covered by automated tests?]: Yes, but the unit test that exercise this path are run sequentially. [Has the fix been verified in Nightly?]: This is a backout request for beta only. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: [Is the change risky?]: Very low risk. [Why is the change risky/not risky?]: This patch only removes code. This code being removed has interaction with other code and is unlikely to cause any regressions. [String changes made/needed]: