Bug 1584170 Comment 37 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
tjr: I checked that before, and at least couldn't come up with a problematic scenario. I've checked it again:

`[mTagStack]`(https://searchfox.org/mozilla-central/search?q=symbol:F_%3CT_nsPlainTextSerializer%3E_mTagStack&redirect=false) is only accessed with indices in [0, TagStackSize), hence it should be safe.

However, in general it'd be safer to replace all arrays allocated with `new[]` (like [`mTagStack`](https://searchfox.org/mozilla-central/rev/cce8b90aece0f42e5025e45282de16066eeaa662/dom/base/nsPlainTextSerializer.cpp#262) with `AutoTArray` or similar classes.
Revision 1 by
on 
tjr: I checked that before, and at least couldn't come up with a problematic scenario. I've checked it again:

`[mTagStack]`(https://searchfox.org/mozilla-central/search?q=symbol:F_%3CT_nsPlainTextSerializer%3E_mTagStack&redirect=false) is only accessed with indices in [0, TagStackSize), hence it should be safe.

However, in general it'd be safer to replace all arrays allocated with `new[]` (like [`mTagStack`](https://searchfox.org/mozilla-central/rev/cce8b90aece0f42e5025e45282de16066eeaa662/dom/base/nsPlainTextSerializer.cpp#262) with `AutoTArray` or similar classes).

Back to Bug 1584170 Comment 37