Bug 1588622 Comment 32 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Andreas Tolfsen  「:ato」 from comment #31)
> Just so I understand this: if Chromium takes screenshots of the full document area as if the scrollbars are not present, would we want to follow Juggler’s example with [ScrollbarManager.js](https://github.com/puppeteer/juggler/blob/master/testing/juggler/content/ScrollbarManager.js) and hide them prior to taking the screenshot?

Would totally make sense also given that there is [Emulation.setScrollbarsHidden()](https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setScrollbarsHidden), which we haven't implemented yet. I will file new bugs and add dependencies. Thanks for noticing that.
(In reply to Andreas Tolfsen  「:ato」 from comment #31)
> Just so I understand this: if Chromium takes screenshots of the full document area as if the scrollbars are not present, would we want to follow Juggler’s example with [ScrollbarManager.js](https://github.com/puppeteer/juggler/blob/master/testing/juggler/content/ScrollbarManager.js) and hide them prior to taking the screenshot?

Would totally make sense also given that there is [Emulation.setScrollbarsHidden()](https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setScrollbarsHidden), which we haven't implemented yet. I filed bug 1604799 for it. Thanks for noticing that.

Back to Bug 1588622 Comment 32