Bug 1590526 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

     [Feature/regressing bug #]: In Bug 1467970 , we unsupported cross docGroup node adoption, but it may prevent some extensions to work properly. This patch allows extensions to continue work properly.
 
    [User impact if declined]: Extension developers may rely on this capability to write their code, so if we unsupported 
it without noticing them, and end users may experience some extensions stop to work. 

   [Describe test coverage new/current, TBPL]: We added three more test cases, and I also did some manual testing after the patch reached to Nightly. 
   [Describe test coverage new/current, TBPL]: What kind of testing was completed here. Manual and/or automated ? Any details about what scenarios the tests cover? If the patch landed on a master/central branch or any other branch did we get verification from reporter or QA?
   [Risks and why]: Medium, the code itself isn't complex, but it impacts an important feature as extensions. 
   [String/UUID change made/needed]: None

### Beta/Release Uplift Approval Request
* **User impact if declined**: End users may experience some extensions stop to work
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Medium
* **Why is the change risky/not risky? (and alternatives if risky)**: Medium, the code itself isn't complex, but it impacts an important feature as extensions.
* **String changes made/needed**: None

### Beta/Release Uplift Approval Request
* **User impact if declined**: End users may experience some extensions stop to work
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Medium
* **Why is the change risky/not risky? (and alternatives if risky)**: Medium, the code itself isn't complex, but it impacts an important feature as extensions.
* **String changes made/needed**: None

### Beta/Release Uplift Approval Request
* **User impact if declined**: End users may experience some extensions stop to work
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: Yes. Unzip the adoptNodeXdocGroup.zip attachment and load it as a temporary addon from about:debugging. Go to example.com, the content of the injected iframe should be bold. 
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Medium
* **Why is the change risky/not risky? (and alternatives if risky)**: Medium, the code itself isn't complex, but it impacts an important feature as extensions.
* **String changes made/needed**: None

Back to Bug 1590526 Comment 11