Bug 1593647 Comment 22 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Franziskus Kiefer [:franziskus] from comment #21)
> > :franziskus, could you work-around this with ENV entries or a file instead of ARG+build-args until we get the image updated? There may be other changes to the image that need to be tested, and so I do not know how long this update will take.
> 
> This is an external docker image. I could try to get something changed upstream for it but was hoping I don't have to go that route...
> 
> > (I looked in the nss and nss-try repos and I don't see ARG usage in the Dockerfiles yet: https://hg.mozilla.org/projects/nss-try/file/acb6a0f742321e33669c46875f8f590b3f68aab2/automation/taskcluster/image_builder/Dockerfile)
> 
> Note that this  is the image builder and not the one that requires `--build-arg`. That's required when building the actual docker image (on the try runs hard-coded here https://hg.mozilla.org/projects/nss-try/file/02837eea37c51d02b5e226a13184238cf379dcfa/automation/taskcluster/scripts/build_image.sh)

I understand. The development branch Dockerfile in hacl+ has a number of ARG entries, and looks like it could be replaced/hard-coded for a task run but that might be fragile unless you're pinning to a specific version (https://github.com/project-everest/hacl-star/blob/fstar-master/.docker/build/linux/Dockerfile).
(In reply to Franziskus Kiefer [:franziskus] from comment #21)
> > :franziskus, could you work-around this with ENV entries or a file instead of ARG+build-args until we get the image updated? There may be other changes to the image that need to be tested, and so I do not know how long this update will take.
> 
> This is an external docker image. I could try to get something changed upstream for it but was hoping I don't have to go that route...
> 
> > (I looked in the nss and nss-try repos and I don't see ARG usage in the Dockerfiles yet: https://hg.mozilla.org/projects/nss-try/file/acb6a0f742321e33669c46875f8f590b3f68aab2/automation/taskcluster/image_builder/Dockerfile)
> 
> Note that this  is the image builder and not the one that requires `--build-arg`. That's required when building the actual docker image (on the try runs hard-coded here https://hg.mozilla.org/projects/nss-try/file/02837eea37c51d02b5e226a13184238cf379dcfa/automation/taskcluster/scripts/build_image.sh)

I understand. The development branch Dockerfile in hacl-star has a number of ARG entries, and looks like it could be replaced/hard-coded for a task run but that might be fragile unless you're pinning to a specific version (https://github.com/project-everest/hacl-star/blob/fstar-master/.docker/build/linux/Dockerfile).

Back to Bug 1593647 Comment 22