Bug 1593825 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Dão Gottwald [::dao] from comment #2)
> Why? We can draw perfect circles with CSS, plus we have scalable tab and bookmark icons that we could reuse here unless they don't scale nicely to this small size.

That's the thought indeed... my experience is - generally - that scaling vector icons up is no trouble at all, but when scaling them down they tend to need different shapes to get the same visual expression. This became clear to me right away when looking at the swith-to-tab icon. They might also be considered to not match the Photon tab style currently (since the icon shows a curvy tab).

Drawing the circle with CSS seems like the past plan, because you can work with different contrast modes easier that way, since we generally work with only one fill-color for icons.
(In reply to Dão Gottwald [::dao] from comment #2)
> Why? We can draw perfect circles with CSS, plus we have scalable tab and bookmark icons that we could reuse here unless they don't scale nicely to this small size.

That's the thought indeed... my experience is - generally - that scaling vector icons up is no trouble at all, but when scaling them down they tend to need different shapes to get the same visual expression. This became clear to me right away when looking at the swith-to-tab icon. They might also be considered to not match the Photon tab style currently (since the icon shows a curvy tab).

Drawing the circle with CSS seems like your plan, because you can work with different contrast modes easier that way, since we generally work with only one fill-color for icons.
(In reply to Dão Gottwald [::dao] from comment #2)
> Why? We can draw perfect circles with CSS, plus we have scalable tab and bookmark icons that we could reuse here unless they don't scale nicely to this small size.

That's the thought indeed... my experience is - generally - that scaling vector icons up is no trouble at all, but when scaling them down they tend to need different shapes to get the same visual expression. This became clear to me right away when looking at the swith-to-tab icon. They might also be considered to not match the Photon tab style currently (since the icon shows a curvy tab).

Drawing the circle with CSS seems like the right plan, because you can work with different contrast modes easier that way, since we generally work with only one fill-color for icons.

Back to Bug 1593825 Comment 3