Bug 1594860 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> Sotaro, do we know how Chromium gets access to the hidden APIs?

For java side, chromium has some implementations of com.android.webview.chromium as glue. For native side, chromium has definitions like the following.
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h

--------------------------------------------------------------------------------
Some details

- com.android.webview.chromium
   + chromium source code implements part of com.android.webview.chromium and provide access to com.android.webview.chromium from org.chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/
   + Java functor handling also exists here.
- com.android.webview.chromium.GraphicsUtils
   + It is used to get function tables of SW and HW rendering.
   + It is not a public method, then we could not access to the class from another package.
   + Java class is defined in chromium, but native implementation is in android framework.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/graphics_utils.cpp#74
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/graphics_utils.cpp#82
   + In chromium, com.android.webview.chromium.SharedWebViewChromium is defined as a public class, and it provides access to the GraphicsUtils.
   + Native side definitions exist in chromium in the following.
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
- Get DrawFunctor table is defined in chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/DrawFunctor.java
   + Native side of function table definitions exist in chromium in the following.
   + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> Sotaro, do we know how Chromium gets access to the hidden APIs?

For java side, chromium has some implementations of com.android.webview.chromium as glue. For native side, chromium has definitions like the following.
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h

--------------------------------------------------------------------------------
Some details

- com.android.webview.chromium
   + chromium source code implements part of com.android.webview.chromium and provide access to com.android.webview.chromium from org.chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/
   + Java functor handling also exists here.
- com.android.webview.chromium.GraphicsUtils
   + It is used to get function tables of SW and HW rendering.
   + It is not a public method, then we could not access to the class from another package.
   + Java class is defined in chromium, but native implementation is in android framework.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/graphics_utils.cpp#94
   + In chromium, com.android.webview.chromium.SharedWebViewChromium is defined as a public class, and it provides access to the GraphicsUtils.
   + Native side definitions exist in chromium in the following.
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
- Get DrawFunctor table is defined in chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/DrawFunctor.java
   + Native side of function table definitions exist in chromium in the following.
   + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> Sotaro, do we know how Chromium gets access to the hidden APIs?

For java side, chromium has some implementations of com.android.webview.chromium as glue. For native side, chromium has definitions like the following.
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h

--------------------------------------------------------------------------------
Some details

- com.android.webview.chromium
   + chromium source code implements part of com.android.webview.chromium and provide access to com.android.webview.chromium from org.chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/
   + Java functor handling also exists here.
- com.android.webview.chromium.GraphicsUtils
   + It is used to get function tables of SW and HW rendering.
   + It is not a public method, then we could not access to the class from another package.
   + Java class is defined in chromium, but native implementation is in android framework.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/graphics_utils.cpp#94
   + In chromium, com.android.webview.chromium.SharedWebViewChromium is defined as a public class, and it provides access to the GraphicsUtils.
   + Native side definitions exist in chromium in the following.
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
- Get DrawFunctor table is defined in chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/DrawFunctor.java
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/draw_gl_functor.cpp#113
   + Native side of function table definitions exist in chromium in the following.
   + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> Sotaro, do we know how Chromium gets access to the hidden APIs?

For java side, chromium has some implementations of com.android.webview.chromium as glue. For native side, chromium has definitions like the following.
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h

--------------------------------------------------------------------------------
Some details

- com.android.webview.chromium
   + chromium source code implements part of com.android.webview.chromium and provide access to com.android.webview.chromium from org.chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/
   + Java functor handling also exists here.
- com.android.webview.chromium.GraphicsUtils
   + It is used to get function tables of SW and HW rendering.
   + It is not a public method, then we could not access to the class from another package.
   + Java class is defined in chromium, but native implementation is in android framework.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/graphics_utils.cpp#94
   + In chromium, com.android.webview.chromium.SharedWebViewChromium is defined as a public class, and it provides access to the GraphicsUtils.
   + Native side definitions exist in chromium in the following.
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
- Get DrawFunctor table is defined in chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/DrawFunctor.java
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/draw_functor.cpp#219
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/draw_gl_functor.cpp#113
   + Native side of function table definitions exist in chromium in the following.
   + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> Sotaro, do we know how Chromium gets access to the hidden APIs?

For java side, chromium has some implementations of com.android.webview.chromium as glue. For native side, chromium has definitions like the following.
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h

--------------------------------------------------------------------------------
Some details

- com.android.webview.chromium
   + chromium source code implements part of com.android.webview.chromium and provide access to com.android.webview.chromium from org.chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/
   + Java functor handling also exists here.
- com.android.webview.chromium.GraphicsUtils
   + It is used to get function tables of SW and HW rendering.
   + It is not a public method, then we could not access to the class from another package.
   + Java class is defined in chromium, but native implementation is in android framework.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/graphics_utils.cpp#94
   + In chromium, com.android.webview.chromium.SharedWebViewChromium is defined as a public class, and it provides access to the GraphicsUtils.
   + Native side definitions exist in chromium in the following.
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
- Get DrawFunctor table is defined in chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/DrawFunctor.java
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/draw_functor.cpp#219
   + Native side of function table definitions exist in chromium in the following.
   + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> Sotaro, do we know how Chromium gets access to the hidden APIs?

For java side, chromium has some implementations of com.android.webview.chromium as glue. For native side, chromium has definitions like the following.
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h

--------------------------------------------------------------------------------
Some details

- com.android.webview.chromium
   + chromium source code implements part of com.android.webview.chromium and provide access to com.android.webview.chromium from org.chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/
   + Java functor handling also exists here.
- com.android.webview.chromium.GraphicsUtils
   + It is used to get function tables of SW and HW rendering.
   + It is not a public method, then we could not access to the class from another package.
   + Java class is defined in chromium, but native implementation is in android framework.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/graphics_utils.cpp#94
   + In chromium, com.android.webview.chromium.SharedWebViewChromium is defined as a public class, and it provides access to the GraphicsUtils.
   + Native side definitions exist in chromium in the following.
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
- Get DrawFunctor table is defined in chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/DrawFunctor.java
   + Native side of DrawFunctor is defined in android.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/draw_functor.cpp#219
   + Native side of function table definitions exist in chromium in the following.
   + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> Sotaro, do we know how Chromium gets access to the hidden APIs?

For java side, chromium has some implementations of com.android.webview.chromium as glue. For native side, chromium has definitions like the following.
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
     + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h

--------------------------------------------------------------------------------
Some details

- com.android.webview.chromium
   + chromium source code implements part of com.android.webview.chromium and provide access to com.android.webview.chromium from org.chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/
   + Java functor handling also exists here.
- com.android.webview.chromium.GraphicsUtils
   + It is used to get function tables of SW and HW rendering.
   + It is not a public method, then we could not access to the class from another package.
   + Java class is defined in chromium, but native implementation is in android framework.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/graphics_utils.cpp#94
   + In chromium, com.android.webview.chromium.SharedWebViewChromium is defined as a public class, and it provides access to the GraphicsUtils.
   + Native side definitions exist in chromium in the following.
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_gl.h
     https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_sw.h
- Get DrawFunctor table is defined in chromium.
   + https://cs.chromium.org/chromium/src/android_webview/glue/java/src/com/android/webview/chromium/DrawFunctor.java
   + Native side of DrawFunctor is defined in android.
   + https://android.googlesource.com/platform/frameworks/base/+/master/native/webview/plat_support/draw_functor.cpp#219
   + Native side of draw functor definitions exist in chromium in the following.
   + https://cs.chromium.org/chromium/src/android_webview/public/browser/draw_fn.h

Back to Bug 1594860 Comment 12