Bug 1595064 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to :Gijs (he/him) from comment #8)
> Jonas, any chance you're interested in looking at this?

I'm honestly not really sure what I'm being asked to do here, since for starters this "issue" affects Reader Mode too (as you mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1595064#c4)!?

While it would obviously be technically *feasible* to e.g. propagate the PDF Viewer zoom values to the Firefox menu, that's not going to be as simple as you'd probably wish. The reason is that the PDF Viewer, in addition to allow zooming to arbitrary percentage values, also supports a few "special" zoom values (i.e. "Automatic Zoom", "Actual Size", Page Fit", and "Page Width") which I cannot image would play nice with the zoom label in the Firefox menu.

Finally, I'm not sure that I really agree with labelling this a regression from bug 786674, since prior to that being fixed zooming via e.g. the Firefox menu didn't really work well *at all* with the PDF Viewer (again similar to Reader Mode).
(In reply to :Gijs (he/him) from comment #8)
> Jonas, any chance you're interested in looking at this?

I'm honestly not really sure what I'm being asked to do here, since for starters this "issue" affects Reader Mode too (as you mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1595064#c4)!?

While it would obviously be *technically* feasible to e.g. propagate the PDF Viewer zoom values to the Firefox menu, that's not going to be as simple as you'd probably wish. The reason is that the PDF Viewer, in addition to allow zooming to arbitrary percentage values, also supports a few "special" zoom values (i.e. "Automatic Zoom", "Actual Size", Page Fit", and "Page Width") which I cannot image would play nice with the zoom label in the Firefox menu.

Finally, I'm not sure that I really agree with labelling this a regression from bug 786674, since prior to that being fixed zooming via e.g. the Firefox menu didn't really work well *at all* with the PDF Viewer (again similar to Reader Mode).

Back to Bug 1595064 Comment 9