Some instructions for anyone interested in fixing this bug: 1) The list of frames is rendered here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#231 2) The `frames` property is calculated using `getDisplayedFrames` method here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#345 3) `getDisplayedFrames` is implemented here https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/selectors/web-sockets.js#13 Note that this method returns list that is already filtered (based on the UI mentioned in the STRs, comment #0) 4) Finally, there is a code that calculates the final number of rendered frames here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#245-262 This logic involves: * Frames returned by `getDisplayedFrames` * The frame limit give by `devtools.netmonitor.ws.displayed-frames.limit` pref * State of the `Keep all future messages` checkbox Something seems to be wrong around how this calculation is done. Honza
Bug 1595119 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Some instructions for anyone interested in fixing this bug: 1) The list of frames is rendered here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#231 2) The `frames` property is calculated using `getDisplayedFrames` method here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#345 3) `getDisplayedFrames` is implemented here https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/selectors/web-sockets.js#13 Note that this method returns list that is already filtered (based on the UI mentioned in the STRs, comment #0) 4) Finally, there is a code that calculates the final number of rendered frames here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#245-262 This logic involves: * Frames returned by `getDisplayedFrames` * The frame limit given by `devtools.netmonitor.ws.displayed-frames.limit` pref * State of the `Keep all future messages` checkbox Something seems to be wrong around how this calculation is done. Honza
Some instructions for anyone interested in fixing this bug: 1) The list of frames is rendered here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#231 2) The `frames` property is calculated using `getDisplayedFrames` method here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#345 3) `getDisplayedFrames` is implemented here https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/selectors/web-sockets.js#13 Note that this method returns list that is already filtered (based on the UI mentioned in the STRs, comment #0) 4) Finally, there is a code that calculates the final number of rendered frames here: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/devtools/client/netmonitor/src/components/websockets/FrameListContent.js#245-262 This logic involves: * Frames returned by `getDisplayedFrames` * The frame limit given by `devtools.netmonitor.ws.displayed-frames.limit` pref * State of the `Keep all future messages` checkbox Something is wrong around how this calculation is done. Honza