Bug 1595119 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Some more comments:

1) The backend is creating `LongStringActor` for every sent/received frame payload here
https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/devtools/server/actors/network-monitor/websocket-actor.js#106,131

These actors are not explicitly removed (e.g. when they would reach a limit)

2) The client side is handling WS sent/received notifications here:
https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/devtools/client/netmonitor/src/connector/firefox-data-provider.js#468,478

This fires Redux action `WS_ADD_FRAME`

3) The action is handled by WS reducer here:
https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/devtools/client/netmonitor/src/reducers/web-sockets.js#82

It adds WS frame into a `frames` map.

There is no logic that would explicitly remove frames from the map when reaching a limit.

-

I am raising the priority since this could be perf/memory issue.

Honza
Some more comments:

1) The backend is creating `LongStringActor` for every sent/received frame payload here
https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/devtools/server/actors/network-monitor/websocket-actor.js#106,131

These actors are not explicitly removed (e.g. when they would reach a limit)

2) The client side is handling WS sent/received notifications here:
https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/devtools/client/netmonitor/src/connector/firefox-data-provider.js#468,478

This fires Redux action `WS_ADD_FRAME`

3) The action is handled by WS reducer here:
https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/devtools/client/netmonitor/src/reducers/web-sockets.js#82

It adds WS frame into a `frames` map.

There is no logic that would explicitly remove frames from the map when reaching a limit.

---

I am raising the priority since this could be perf/memory issue.

Honza

Back to Bug 1595119 Comment 5