Yes, that fixes GetDialogParent() and makes the test pass and let's me open attachments in the compose window again. I can submit this as a patch, but I don't feel that would be right since I didn't write any of it really. Maybe you can submit it. If you do, please fix the first badly indented lines in nsExternalHelperAppService::DoContent() and also make the lines in your patch fix the 80 char limit (or run clang-format).
Bug 1595747 Comment 29 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Yes, that fixes GetDialogParent() and makes the test pass and let's me open attachments in the compose window again. I can submit this as a patch, but I don't feel that would be right since I didn't write any of it really. Maybe you can submit it. If you do, please fix the first badly indented lines in nsExternalHelperAppService::DoContent() and also make the lines in your patch ~~fix~~ fit the 80 char limit (or run clang-format).