Alternatively we can just disable this code for nightly, but keep it enabled for debug. That'll fix the inlining problem for dmajor but it keeps the canary checking in there. But that's probably not useful because we already run asan as much as debug and asan may be protecting against 99% of the cases the canary can protect for. Just a thought in case anyone wanted to keep this for debug builds.
Bug 1596198 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Alternatively we can just disable this code for nightly, but keep it enabled for debug. That'll fix the inlining problem for dmajor but it keeps the canary checking in there. But that's probably not useful because we already run asan as much as debug and asan may be protecting against 99% of the cases the canary can protect for. Just a thought in case anyone wanted to keep this for debug builds. bz do you have any thoughts since I added this canary based on Bug 1403397 comment 26