Bugzilla

I'm taking a closer look at this and aboutDialog-appUpdater.js, and it looks like there are a couple of other complications. The update also may be downloading, which `isBrowserUpdateReadyToInstall` doesn't capture. Also, auto update may be disabled, and in that case updates aren't automatically downloaded in the background.

So the ideal seems something like this:

    if isBrowserUpdateReadyToInstall:
      prompt to restart
    else if update is downloading:
      ??? show a progress bar?
    else if auto update is not enabled:
      prompt to check for update
    else:
      trigger an update check
      if there's an error:
        prompt to download
      else if no update available:
        prompt to refresh
      else:
        recurse (but skip the else branch and don't trigger an update check)

I don't think we should actually do this because it's more work than we should put into it since we're talking about an experiment and we want to ship soon, but if this were a feature in Firefox, this seems like what we would want to do.

I think we should do this:

    if isBrowserUpdateReadyToInstall:
      prompt to restart
    else:
      show a prompt that opens the update section of about:preferences

Or maybe:

    if isBrowserUpdateReadyToInstall:
      prompt to restart
    else if updates aren't allowed:
      prompt to download
    else:
      show a prompt that opens the update section of about:preferences

What do you think?

I'm taking a closer look at this and aboutDialog-appUpdater.js, and it looks like there are a couple of other complications. The update also may be downloading, which `isBrowserUpdateReadyToInstall` doesn't capture. Also, auto update may be disabled, and in that case updates aren't automatically downloaded in the background.

So the ideal seems something like this:

    if isBrowserUpdateReadyToInstall:
      prompt to restart
    else if update is downloading:
      ??? show a progress bar?
    else if auto update is not enabled:
      prompt to check for update
    else:
      trigger an update check
      if there's an error:
        prompt to download
      else if no update available:
        prompt to refresh
      else:
        recurse (but skip the else branch and don't trigger an update check)

I don't think we should actually do this because it's more work than we should put into it since we're talking about an experiment and we want to ship soon, but if this were a feature in Firefox, this seems like what we would want to do.

I think we should do this:

    if isBrowserUpdateReadyToInstall:
      prompt to restart
    else:
      show a prompt that opens the update section of about:preferences

Or maybe:

    if isBrowserUpdateReadyToInstall:
      prompt to restart
    else if updates aren't allowed:
      prompt to download
    else:
      show a prompt that opens the update section of about:preferences

i.e., we should delegate to the update logic/UI that we already have instead of writing a new UI for it.

What do you think?