Bug 1597894 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Since updating to moz-phab 0.1.61 it has stopped working in my git-cinnabar-based checkout.

```
$ moz-phab submit --upstream=bookmarks/central
Determining the commit range using upstream "bookmarks/central"
Git Cinnabar extension is required to work on this repository.
Local VCS (git) is different from the one defined in the repository (hg).
```

I do have git-cinnabar installed and in my path and it worked fine before the update. From reading the source code it looks like it is checking to see whether the string `cinnabar` is present in `git help --all`, which it is not, so I don't think this is a 

```
$ git-cinnabar
usage: git-cinnabar [-h] [--version [{cinnabar,module,helper}]]
                    {data,fsck,upgrade,reclone,fetch,hg2git,git2hg,bundle,unbundle,rollback,python,download}
                    ...
git-cinnabar: error: too few arguments
$ git cinnabar
usage: git-cinnabar [-h] [--version [{cinnabar,module,helper}]]
                    {data,fsck,upgrade,reclone,fetch,hg2git,git2hg,bundle,rollback,python,download}
                    ...
git-cinnabar: error: too few arguments
$ git help --all | grep cinnabar
$
```

Downgrading to moz-phab 0.1.60 fixes the problem.
Since updating to moz-phab 0.1.61 it has stopped working in my git-cinnabar-based checkout.

```
$ moz-phab submit --upstream=bookmarks/central
Determining the commit range using upstream "bookmarks/central"
Git Cinnabar extension is required to work on this repository.
Local VCS (git) is different from the one defined in the repository (hg).
```

I do have git-cinnabar installed and in my path and it worked fine before the update. From reading the source code it looks like it is checking to see whether the string `cinnabar` is present in `git help --all`, which it is not, so I don't think this is a 100% accurate way to check if git-cinnabar is present.

```
$ git-cinnabar
usage: git-cinnabar [-h] [--version [{cinnabar,module,helper}]]
                    {data,fsck,upgrade,reclone,fetch,hg2git,git2hg,bundle,unbundle,rollback,python,download}
                    ...
git-cinnabar: error: too few arguments
$ git cinnabar
usage: git-cinnabar [-h] [--version [{cinnabar,module,helper}]]
                    {data,fsck,upgrade,reclone,fetch,hg2git,git2hg,bundle,rollback,python,download}
                    ...
git-cinnabar: error: too few arguments
$ git help --all | grep cinnabar
$
```

Downgrading to moz-phab 0.1.60 fixes the problem.

Back to Bug 1597894 Comment 0