Bugzilla

I am not entirely happy with this. Moving this into ToolbarButtonAPI is indeed very nice and the toolbox -> toolbar lookup is great - but `onUninstall` is static and I have no access to the class `this` which I need for proper cleanup.

I moved the uninstall part into `onShutdown` where I can only differentiate between shutdown and disable. So the position of the buttons is now kept between restarts, but will be reset to default on disable/enable. Is there any way we can detect uninstall in onShutdown? I failed to find a way.

Furthermore, this currently breaks composeAction, as it does things differently and would need adjustment (which is doable but I skipped it for now). Have not looked as messageDisplayAction, but as this is currently not even a customizable toolbar, this needs further adjustments.

If I would have a say, I would keep it in browserAction, but use the nice toolbox -> toolbar lookup.

I am not entirely happy with this. Moving this into ToolbarButtonAPI is indeed very nice and the toolbox -> toolbar lookup is great - but `onUninstall` is static and I have no access to the class `this` which I need for proper cleanup.

I moved the uninstall part into `onShutdown` where I can only differentiate between shutdown and disable. So the position of the buttons is now kept between restarts, but will be reset to default on disable/enable. Is there any way we can detect uninstall in onShutdown? I failed to find a way.

Furthermore, this currently breaks composeAction, as it does things differently and would need adjustment (which is doable but I skipped it for now). Have not looked at messageDisplayAction, but as this is currently not even a customizable toolbar, this needs further adjustments.

If I would have a say, I would keep it in browserAction, but use the nice toolbox -> toolbar lookup.

I am not entirely happy with this. Moving this into ToolbarButtonAPI is indeed very nice and the toolbox -> toolbar lookup is great - but `onUninstall` is static and I have no access to the class `this` which I need for proper cleanup.

I moved the uninstall part into `onShutdown` where I can only differentiate between shutdown and disable. So the position of the buttons is now kept between restarts, but will be reset to default on disable/enable. Is there any way we can detect uninstall in onShutdown? I failed to find a way.

Furthermore, this currently breaks composeAction, as it does things differently and would need adjustment (which is doable but I skipped it for now). Have not looked at messageDisplayAction, but as this is currently not even a customizable toolbar, this needs further adjustments.

If I would have a say, I would keep it in browserAction, but use the nice toolbox -> toolbar lookup.

Edit: I forgot a console.log in the patch. That has to be removed of course.