Bug 1598362 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(Yeah, I hit this in Chrome as well when viewing the replay of today's internal meeting, and I verified that the main "pane" on AirMo is hosted in an iframe, and the redirect is just redirecting that iframe (the lower part of the viewport), which is why this runs afoul of mozilla.org's X-Frame-Options selections.

It's possible that there are other STR here that trigger a Firefox-nightly-with-fission-specific issue (maybe for a scenario where the whole tab is redirected and mistakenly runs afoul of this, rather than just an iframe being redirected? It looks like that in the comment 0 screenshot, I think).

But the issues that we're seeing here in comment 9 - 11 (for today's meeting at least) are unrelated to fisison and are simply a combination of the fact that: (1) AirMo is doing its video-is-over redirect inside an iframe, and (2) it's redirecting to a page that refuses to be framed via `X-Frame-Options`.

Andy and I discussed this in Slack a bit and I believe he's going to disable the redirect AirMo feature for now, so this will probably end up being fixed via that AirMo change. If there are still changes we want to make on the fission side, though, it might be good to come up with an alternate testcase or alternate of STR in order to keep track of whatever (if anything) is still broken & needing fixing on the Firefox-with-fission side here.
Yeah, I hit this in Chrome as well when viewing the replay of today's internal meeting, and I verified that the main "pane" on AirMo is hosted in an iframe, and the redirect is just redirecting that iframe (the lower part of the viewport, separate from AirMo's header-bar with its top-left hamburger menu and top-right search icon). And that's why this runs afoul of the X-Frame-Options preferences of mozilla.org, the redirect-target in this case.

It's possible that there are some specific STR that trigger an issue that is specific to Firefox-nightly-with-fission (maybe for a scenario where the whole tab is redirected and mistakenly runs afoul of this, rather than just an iframe being redirected? It looks like that in the comment 0 screenshot, I think).

But the issues that we're seeing here in comment 9 - 11 (for today's meeting at least) are unrelated to fisison and are simply a combination of the fact that: (1) AirMo is doing its video-is-over redirect inside an iframe, and (2) it's redirecting to a page that refuses to be framed via `X-Frame-Options`.

Andy and I discussed this in Slack a bit and I believe he's going to disable the redirect AirMo feature for now, so this will probably end up being fixed via that AirMo change. If there are still changes we want to make on the fission side, though, it might be good to come up with an alternate testcase or alternate of STR in order to keep track of whatever (if anything) is still broken & needing fixing on the Firefox-with-fission side here.
Yeah, I hit this in Chrome as well when viewing the replay of today's internal meeting, and I verified that the main "pane" on AirMo is hosted in an iframe, and the redirect is just redirecting that iframe (the lower part of the viewport, separate from AirMo's header-bar with its top-left hamburger menu and top-right search icon). And that's why this runs afoul of the X-Frame-Options preferences of mozilla.org, the redirect-target in this case.

It's possible that there are some specific STR that trigger an issue that is specific to Firefox-nightly-with-fission (maybe for a scenario where the whole tab is redirected and mistakenly runs afoul of this, rather than just an iframe being redirected? It looks like that in the comment 0 screenshot, I think).

But the issues that we're seeing here in comment 9 - 11 (for today's meeting at least) are unrelated to fisson and are simply a combination of the fact that: (1) AirMo is doing its video-is-over redirect inside an iframe, and (2) it's redirecting to a page that refuses to be framed via `X-Frame-Options`.

Andy and I discussed this in Slack a bit and I believe he's going to disable the redirect AirMo feature for now, so this will probably end up being fixed via that AirMo change. If there are still changes we want to make on the fission side, though, it might be good to come up with an alternate testcase or alternate of STR in order to keep track of whatever (if anything) is still broken & needing fixing on the Firefox-with-fission side here.
Yeah, I hit this in Chrome as well when viewing the replay of today's internal meeting, and I verified that the main "pane" on AirMo is hosted in an iframe, and the redirect is just redirecting that iframe (the lower part of the viewport, separate from AirMo's header-bar with its top-left hamburger menu and top-right search icon). And that's why this runs afoul of the X-Frame-Options preferences of mozilla.org, the redirect-target in this case.

It's possible that there are some specific STR that trigger an issue that is specific to Firefox-nightly-with-fission (maybe for a scenario where the whole tab is redirected and mistakenly runs afoul of this, rather than just an iframe being redirected? It looks like that in the comment 0 screenshot, I think).

But the issues that we're seeing here in comment 9 - 11 (for today's meeting at least) are unrelated to fisson (and aren't Firefox-specific); they're simply a combination of the fact that: (1) AirMo is doing its video-end redirect inside an iframe, and (2) it's redirecting to a page that refuses to be framed via `X-Frame-Options`.

Andy and I discussed this in Slack a bit and I believe he's going to disable the redirect AirMo feature for now, so this will probably end up being fixed via that AirMo change. If there are still changes we want to make on the fission side, though, it might be good to come up with an alternate testcase or alternate of STR in order to keep track of whatever (if anything) is still broken & needing fixing on the Firefox-with-fission side here.
Yeah, I hit this in Chrome as well when viewing the replay of today's internal meeting, and I verified that the main "pane" on AirMo is hosted in an iframe, and the redirect is just redirecting that iframe (the lower part of the viewport, separate from AirMo's header-bar with its top-left hamburger menu and top-right search icon). And that's why this runs afoul of the X-Frame-Options preferences of mozilla.org, the redirect-target in this case.

It's possible that there are some specific STR that trigger an issue that is specific to Firefox-nightly-with-fission (maybe for a scenario where the whole tab is redirected and mistakenly runs afoul of this, rather than just an iframe being redirected? It looks like that in the comment 0 screenshot, I think).

But the issues that we're seeing here in comment 9 - 11 (for today's meeting at least) are unrelated to fisson (and aren't Firefox-specific); they're simply a combination of the fact that: (1) AirMo is doing its video-end redirect inside an iframe, and (2) it's redirecting to a page that refuses to be framed via `X-Frame-Options`.

Andy and I discussed this in Slack a bit and I believe he's going to disable the redirect AirMo feature for now, so this will probably end up being fixed via that AirMo change. If there are still changes we want to make on the fission side, though, it might be good to come up with an alternate testcase or alternate non-AirMo-dependent STR, in order to keep track of whatever (if anything) is still broken & needing fixing on the Firefox-with-fission side here.

Back to Bug 1598362 Comment 12