The artifacts that generic-worker has hardcoded paths for are the following logs files: * `public/logs/live_backing.log` * `public/logs/live.log` * `public/logs/certified.log` and the following non-log files: * `public/chain-of-trust.json` * `public/chain-of-trust.json.sig` * `public/superseded-by.json` I suspect we'd want to keep the non-logfiles public for now, so just have a setting for changing the location of `public/logs` (since probably chain of trust signatures and superseded information could always reasonably be public). It is hard to think of a good name, I think a term involving "path" could possibly be misleading since in generic-worker, under the artifact declaration, "path" refers to the filesystem path, and "name" refers to the artifact name. That said, I haven't come up with a better name in the last few minutes, maybe I'll sleep on it and add a comment if I come up with a better name! In principle though, I'm in favour of being able to override the artifact paths. .... Maybe I'm overthinking it, maybe we add a payload property `"logPath"` with default setting `"public/logs"` ??
Bug 1598689 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
The artifacts that generic-worker has hardcoded paths for are the following logs files: * `public/logs/live_backing.log` * `public/logs/live.log` * `public/logs/certified.log` and the following non-log files: * `public/chain-of-trust.json` * `public/chain-of-trust.json.sig` * `public/superseded-by.json` I suspect we'd want to keep the non-logfiles public for now, so just have a setting for changing the location of `public/logs` (since probably chain of trust signatures and superseded information could always reasonably be public). It is hard to think of a good name, I think a term involving "path" could possibly be misleading since in generic-worker, under the artifact declaration, "path" refers to the filesystem path, and "name" refers to the artifact name. That said, I haven't come up with a better name in the last few minutes, maybe I'll sleep on it and add a comment if I come up with a better name! In principle though, I'm in favour of being able to override the artifact paths. .... Maybe I'm overthinking it, maybe we add an optional payload property `"logPath"` with default setting `"public/logs"` ??
The artifacts that generic-worker has hardcoded paths for are the following logs files: * `public/logs/live_backing.log` * `public/logs/live.log` * `public/logs/certified.log` and the following non-log files: * `public/chain-of-trust.json` * `public/chain-of-trust.json.sig` * `public/superseded-by.json` I suspect we'd want to keep the non-logfiles public for now, so just have a setting for changing the location of `public/logs` (since probably chain of trust signatures and superseded information could always reasonably be public). It is hard to think of a good name, I think a term involving "path" could possibly be misleading since in generic-worker, under the artifact declaration, "path" refers to the filesystem path, and "name" refers to the artifact name. That said, I haven't come up with a better name in the last few minutes, maybe I'll sleep on it and add a comment if I come up with a better name! In principle though, I'm in favour of being able to override the artifact paths. .... Maybe I'm overthinking it, maybe we add an optional payload (string) property `"logPath"` with default value `"public/logs"` ??