While working on "Fission for awsy task", i found that there are some issues on Mac OS X, when using the marionette.get_pref() for "fission.autostart=true" pref. The value returned is always False and it seems that this is caused by some extra quotes. More details here: https://phabricator.services.mozilla.com/D48660#1657547 if self.marionette.get_pref('fission.autostart') or \ self.marionette.get_pref('"fission.autostart"'): self._extra_opts.append("fission-enabled") I did a push to try https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=278192169&revision=4bf7c89c2b5740c0c26f0f23b49c76db4022c93d with the patch from https://phabricator.services.mozilla.com/D48660 and i added these lines: print('------------->>>>> Marionette prefs') + print(self.marionette.get_pref('fission.autostart')) + print(self.marionette.get_pref("fission.autostart")) + print(self.marionette.get_pref('"fission.autostart"')) + print(self.marionette.get_pref("'fission.autostart'")) In the logs for the fission job on Mac OS X, where fission.autostart=true we have these values for the print statements above: INFO - ------------->>>>> Marionette prefs INFO - False INFO - False INFO - None INFO - None This is affecting the names of the subtests that appear under Performance Tab https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=278192169&revision=4bf7c89c2b5740c0c26f0f23b49c76db4022c93d where we have Perfherder: Explicit Memory opt stylo tp6: 532111348.16 Heap Unclassified opt stylo tp6: 131473216.43 Images opt stylo tp6: 7797373.46 JS opt stylo tp6: 199633608.83 Resident Memory opt stylo tp6: 558282068.06 But it should be : Perfherder: Explicit Memory fission-enabled opt stylo tp6: 532111348.16 Heap Unclassified fission-enabled opt stylo tp6: 131473216.43 Images fission-enabled opt stylo tp6: 7797373.46 JS fission-enabled opt stylo tp6: 199633608.83 Resident Memory fission-enabled opt stylo tp6: 558282068.06
Bug 1599495 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
While working on "Fission for awsy task", i found that there are some issues on Mac OS X, when using the marionette.get_pref() for "fission.autostart=true" pref. The value returned is always False and it seems that this is caused by some extra quotes. More details here: https://phabricator.services.mozilla.com/D48660#1657547 if self.marionette.get_pref('fission.autostart') or \ self.marionette.get_pref('"fission.autostart"'): self._extra_opts.append("fission-enabled") I did a push to try https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=278192169&revision=4bf7c89c2b5740c0c26f0f23b49c76db4022c93d with the patch from https://phabricator.services.mozilla.com/D48660 and i added these lines: print('------------->>>>> Marionette prefs') print(self.marionette.get_pref('fission.autostart')) print(self.marionette.get_pref("fission.autostart")) print(self.marionette.get_pref('"fission.autostart"')) print(self.marionette.get_pref("'fission.autostart'")) In the logs for the fission job on Mac OS X, where fission.autostart=true we have these values for the print statements above: INFO - ------------->>>>> Marionette prefs INFO - False INFO - False INFO - None INFO - None This is affecting the names of the subtests that appear under Performance Tab https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=278192169&revision=4bf7c89c2b5740c0c26f0f23b49c76db4022c93d where we have Perfherder: Explicit Memory opt stylo tp6: 532111348.16 Heap Unclassified opt stylo tp6: 131473216.43 Images opt stylo tp6: 7797373.46 JS opt stylo tp6: 199633608.83 Resident Memory opt stylo tp6: 558282068.06 But it should be : Perfherder: Explicit Memory fission-enabled opt stylo tp6: 532111348.16 Heap Unclassified fission-enabled opt stylo tp6: 131473216.43 Images fission-enabled opt stylo tp6: 7797373.46 JS fission-enabled opt stylo tp6: 199633608.83 Resident Memory fission-enabled opt stylo tp6: 558282068.06