Let's make conditioned profiles the default for Firefox, for Raptor and Browsertime. GeckoView-based Android support is still being worked on in bug 1597711, and might still block this bug, partially (depending on how cleanly/permanently we wish to switch conditioned profiles to the default). This will involve, among other things (which will be filed separately, and set to either blocking this bug or bug 1596491), changes to the following: taskcluster/ci/test/raptor.yml * remove condprof: True lines for raptor-tp6-1-firefox - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/taskcluster/ci/test/raptor.yml#50 * remove condprof: True lines for raptor-tp6-1-firefox-cold - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/taskcluster/ci/test/raptor.yml#690 * same for browsertime-tp6-1 (warm and cold variants) - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/taskcluster/ci/test/raptor.yml#1008 taskcluster/taskgraph/transforms/raptor.py * remove build_condprof_tests - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/taskcluster/taskgraph/transforms/raptor.py#171-196 testing/mozharness/mozharness/mozilla/testing/raptor.py * remove with-conditioned-profile flag from config_options - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/mozharness/mozharness/mozilla/testing/raptor.py#136-140 * remove the same for options_extend - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/mozharness/mozharness/mozilla/testing/raptor.py#499-500 testing/raptor/raptor/cmdline.py * remove arg from create_parser - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/cmdline.py#143-145 testing/raptor/raptor/raptor.py * remove with_conditioned_profile variable in init - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#109 * remove with_conditioned_profile mapping/assignment in self.config - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#135 * hard-code self.post_startup_delay (remove conditional which listens for with_conditioned_profile cmd-line arg) - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#172-175 * excepting win64-aarch64 (Windows 10), remove conditional in build_browser_profile - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#210 * remove with_conditioned_profile args from raptor_class - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#1777 * remove with_conditioned_profile conditional check for Browsertime - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#694-695 testing/raptor/raptor/results.py * remove "condprof" annotations from RaptorResultsHandler - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/results.py#178-179 * remove appending "condprof" to extra_options in new_pageload_results - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/results.py#178-179
Bug 1600838 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Let's make conditioned profiles the default for Firefox, for Raptor and Browsertime. GeckoView-based Android support is still being worked on in bug 1597711, and might still block this bug, partially (depending on how cleanly/permanently we wish to switch conditioned profiles to the default). This will involve, among other things (which will be filed separately, and set to either blocking this bug or bug 1596491), changes to the following: taskcluster/ci/test/raptor.yml * remove condprof: True lines for raptor-tp6-1-firefox - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/taskcluster/ci/test/raptor.yml#50 * remove condprof: True lines for raptor-tp6-1-firefox-cold - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/taskcluster/ci/test/raptor.yml#690 * same for browsertime-tp6-1 (warm and cold variants) - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/taskcluster/ci/test/raptor.yml#1008 taskcluster/taskgraph/transforms/raptor.py * remove build_condprof_tests - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/taskcluster/taskgraph/transforms/raptor.py#171-196 testing/mozharness/mozharness/mozilla/testing/raptor.py * remove with-conditioned-profile flag from config_options - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/mozharness/mozharness/mozilla/testing/raptor.py#136-140 * remove the same for options_extend - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/mozharness/mozharness/mozilla/testing/raptor.py#499-500 testing/raptor/raptor/cmdline.py * remove arg from create_parser - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/cmdline.py#143-145 testing/raptor/raptor/raptor.py * remove with_conditioned_profile variable in init - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#109 * remove with_conditioned_profile mapping/assignment in self.config - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#135 * hard-code self.post_startup_delay (remove conditional which listens for with_conditioned_profile cmd-line arg) - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#172-175 * excepting win64-aarch64 (Windows 10), remove conditional in build_browser_profile - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#210 * remove with_conditioned_profile args from raptor_class - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#1777 * remove with_conditioned_profile conditional check for Browsertime - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/raptor.py#694-695 testing/raptor/raptor/results.py * remove "condprof" annotations from RaptorResultsHandler - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/results.py#178-179 * remove appending "condprof" to extra_options in new_pageload_results - https://searchfox.org/mozilla-central/rev/04d8e7629354bab9e6a285183e763410860c5006/testing/raptor/raptor/results.py#178-179