(In reply to Ethan Tseng [:ethan] from comment #7) > Hi Dao, is the megabar still targeting 74? Potentially. > And who's working on it? I've been investigating this but don't have a definite solution yet. Bug 1584101's patch is working in the sense that we set and remove the `urlbar-exceeds-toolbar-bounds` attribute as expected. That is, we set it when focusing the address bar (because it then renders outside the toolbar) and remove it when removing focus. With the megabar design disabled, we only set this attribute when opening the results panel, not when merely focusing the address bar. When bug 1584101's patch landed, the megabar design was temporarily disabled and the regression went away. Now with the megabar enabled, the regression is back. I think this means that either AWSY finishes with the address bar focused or Gecko reserves that texture despite the fact that we set `overflow: -moz-hidden-unscrollable;` on the toolbar after unfocusing the address bar. Timothy or Matt, is the latter theory plausible and is something that could be fixed on the Gecko side?
Bug 1603678 Comment 8 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Ethan Tseng [:ethan] from comment #7) > Hi Dao, is the megabar still targeting 74? Potentially. > And who's working on it? I've been investigating this but don't have a definite solution yet. Bug 1584101's patch is working in the sense that we set and remove the `urlbar-exceeds-toolbar-bounds` attribute as expected. That is, we set it when focusing the address bar (because it then renders outside the toolbar) and remove it when removing focus. With the megabar design disabled, we only set this attribute when opening the results panel, not when merely focusing the address bar. When bug 1584101's patch landed, the megabar design was temporarily disabled and the regression went away. Now with the megabar enabled, the regression is back. I think this means that either AWSY finishes with the address bar focused or Gecko reserves that texture despite the fact that we set `overflow: -moz-hidden-unscrollable;` on the toolbar after unfocusing the address bar. Timothy or Matt, is the latter theory plausible and is this something that could be fixed on the Gecko side?