Bug 1605724 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)
> Tim, applying [this rule](https://searchfox.org/mozilla-central/rev/053826b10f838f77c27507e5efecc96e34718541/toolkit/themes/windows/global/global.css#42-48) to GTK too fixes it.
> 
> It changes the sizes of the icons a bit though. 
That's my main concern, it may also be possible that different GTK distros have different icon sizes.

> An alternative would be to use an HTML `<img>` instead of `list-style-image`, as that'd block onload and we'd have a known point in time where we can call SizeToContent.
I thought about that, but unfortunately, each platform uses a different image, so we'd have to duplicate the `.question-icon` CSS, but adapted for HTML `<img>`.

> Alternatively we could probably override `nsImageFrame::GetIntrinsicSize` so that it works more like `<html:img>` and interacts better with HTML layout.

That sounds fine to me, but I don't know much about how much breakage this would cause. I guess you'll know more about this solution :)
(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)
> Tim, applying [this rule](https://searchfox.org/mozilla-central/rev/053826b10f838f77c27507e5efecc96e34718541/toolkit/themes/windows/global/global.css#42-48) to GTK too fixes it.
> 
> It changes the sizes of the icons a bit though. 

That's my main concern, it may also be possible that different GTK distros have different icon sizes.

> An alternative would be to use an HTML `<img>` instead of `list-style-image`, as that'd block onload and we'd have a known point in time where we can call SizeToContent.

I thought about that, but unfortunately, each platform uses a different image, so we'd have to duplicate the `.question-icon` CSS, but adapted for HTML `<img>`.

> Alternatively we could probably override `nsImageFrame::GetIntrinsicSize` so that it works more like `<html:img>` and interacts better with HTML layout.

That sounds fine to me, but I don't know much about how much breakage this would cause. I guess you'll know more about this solution :)

Back to Bug 1605724 Comment 3